Re: [PATCH 1/1] Char: tty_wakeup cleanup
- From: Tilman Schmidt <tilman@xxxxxxx>
- Date: Sun, 31 Dec 2006 19:08:12 +0100
On Sat, 16 Dec 2006 23:17:00 +0100 (CET), Jiri Slaby wrote:
tty_wakeup cleanup
- remove wake_up_interruptible(&tty->write_wait) surrounding
tty_wakup(tty);
- substitute tty->ldisc.write_wakeup(tty) + wake_up() by tty_wakeup(tty);
Signed-off-by: Jiri Slaby <jirislaby@xxxxxxxxx>
Acked-by: Tilman Schmidt <tilman@xxxxxxx>
(for drivers/isdn/gigaset/interface.c)
---[...]
commit 2acac8f970a75a3dc8466781845ae5d14c3d8988
tree 396cc84d4e198d2a65cd4aa9748aabeab5681ba5
parent 8b380d8b1c3ff7d09d68d467d2f135774cab4086
author Jiri Slaby <jirislaby@xxxxxxxxx> Sat, 16 Dec 2006 22:22:57 +0059
committer Jiri Slaby <jirislaby@xxxxxxxxx> Sat, 16 Dec 2006 22:22:57 +0059
diff --git a/drivers/isdn/gigaset/interface.c b/drivers/isdn/gigaset/interface.c
index 458b646..f13de20 100644
--- a/drivers/isdn/gigaset/interface.c
+++ b/drivers/isdn/gigaset/interface.c
@@ -599,19 +599,9 @@ out:
static void if_wake(unsigned long data)
{
struct cardstate *cs = (struct cardstate *) data;
- struct tty_struct *tty;
-
- tty = cs->tty;
- if (!tty)
- return;
-
- if ((tty->flags & (1 << TTY_DO_WRITE_WAKEUP)) &&
- tty->ldisc.write_wakeup) {
- gig_dbg(DEBUG_IF, "write wakeup call");
- tty->ldisc.write_wakeup(tty);
- }
- wake_up_interruptible(&tty->write_wait);
+ if (cs->tty)
+ tty_wakeup(cs->tty);
}
/*** interface to common ***/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
- References:
- [PATCH 1/1] Char: tty_wakeup cleanup
- From: Jiri Slaby
- [PATCH 1/1] Char: tty_wakeup cleanup
- Prev by Date: Re: [KVM][PATCH] smp_processor_id() and sleeping functions used in invalid context
- Next by Date: Re: [PATCH 2.6.20-rc2] Add a quirk to allow ENE PCI SD card readers to work again
- Previous by thread: [PATCH 1/1] Char: tty_wakeup cleanup
- Next by thread: [patch 0/2] more patches for removable drive bay
- Index(es):
Relevant Pages
|
|
