Re: [patch 2.6.20-rc3 1/3] rtc-cmos driver

On Fri, 5 Jan 2007 10:01:57 -0800
David Brownell <david-b@xxxxxxxxxxx> wrote:

This is an "RTC framework" driver for the "CMOS" RTCs which are standard
on PCs and some other platforms. That's MC146818 compatible silicon.
Advantages of this vs. drivers/char/rtc.c (use one _or_ the other, only
one will be able to claim the RTC irq) include:

Hi David,

good code and well commented, thank you.

I only have some comments:

- I would put anything that is x86 related (pnp,acpi)
in a separate file so that people working on
non x86 systems can have a better grasp of the driver.

- the name should be rtc-mc146818 to be coherent with
the other drivers, but this can cause confusion.

- please put yourself in MODULE_AUTHOR

other than that, I'm fine with the code.

I'd appreciate if someone (Woody?) can test
this code on ARM.

--

Best regards,

Alessandro Zummo,
Tower Technologies - Torino, Italy

http://www.towertech.it

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Relevant Pages