Re: [patch] MTD: fix DOC2000/2001/2001PLUS build error
- From: David Woodhouse <dwmw2@xxxxxxxxxxxxx>
- Date: Mon, 05 Feb 2007 16:33:51 +0000
On Mon, 2007-02-05 at 17:26 +0100, Ingo Molnar wrote:
I come across this frequently -- and I just look at the Kconfig file
to see the dependencies of the option I want to enable. It's usually
very simple.
i come across this problem frequently, and sometimes it's far from
simple and involves half a dozen Kconfigs. For example pick up a Fedora
.config of your choice and disable CONFIG_I2C.
Erm, isn't that _my_ example? I'm willing to bet that it'll take me
hours to turn _off_ CONFIG_I2C because the widespread abuse of 'select'
helpfully turning it back on again for me because I have some video
stuff, or some thermal stuff, etc.
It's got a _lot_ harder recently to turn stuff _off_, as rmk observes.
You don't just look at the option you're interested in; you have to
grep all over the rest of the tree to find the 'select' which is
forcing it on after you turn it off. It's no longer in one place.
yeah.
I think that by blaming Aunt Tillie you might be missing the real
problem.
No, by arbitrarily throwing 'select' into the mix with no real
guidance as to when to use it and when to use normal dependencies,
_that's_ when we're missing the real problem.
we should not have 'select' at all - unless it's some non-code option
that is just a convenience switch for several other config options. A
true dependency is already expressed in one direction via the 'depend
on' directive - no need to express it in the other direction as well,
that only leads to redundancy and to bugs.
Right.
--
dwmw2
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
- References:
- Super Kernel Sunday!
- From: Linus Torvalds
- [patch] MTD: fix DOC2000/2001/2001PLUS build error
- From: Ingo Molnar
- Re: [patch] MTD: fix DOC2000/2001/2001PLUS build error
- From: David Woodhouse
- Re: [patch] MTD: fix DOC2000/2001/2001PLUS build error
- From: Ingo Molnar
- Re: [patch] MTD: fix DOC2000/2001/2001PLUS build error
- From: David Woodhouse
- Re: [patch] MTD: fix DOC2000/2001/2001PLUS build error
- From: Ingo Molnar
- Super Kernel Sunday!
- Prev by Date: Re: [patch] MTD: fix DOC2000/2001/2001PLUS build error
- Next by Date: Re: [patch] MTD: fix DOC2000/2001/2001PLUS build error
- Previous by thread: Re: [patch] MTD: fix DOC2000/2001/2001PLUS build error
- Next by thread: Re: [patch] MTD: fix DOC2000/2001/2001PLUS build error
- Index(es):
Relevant Pages
|