RE: AHCI - remove probing of ata2

Hello Tejun,

I've tested your patch yesterday, but no luck, I can't find any difference
in the resulting boot log.

Please find attached an archive containing :
- dmesg.2.6.20-rc7 : full dmesg with stock kernel
- dmesg.patch : full dmesg with your patch included.

I've also added a lspci -vvv, a cat /proc/interrupts and a cat /proc/ioports
in case this could help.

Also, please note that libata is complaining :
ATA: abnormal status 0x7F on port 0x177
and later :
ATA: abnormal status 0x7F on port 0x9807

I don't know if this is important or not.

Sorry for the bad news,
Regards,
Paul

Paul Rolland, rol(at)as2917.net
ex-AS2917 Network administrator and Peering Coordinator

--

Please no HTML, I'm not a browser - Pas d'HTML, je ne suis pas un navigateur
"Some people dream of success... while others wake up and work hard at it"

"I worry about my child and the Internet all the time, even though she's too
young to have logged on yet. Here's what I worry about. I worry that 10 or 15
years from now, she will come to me and say 'Daddy, where were you when they
took freedom of the press away from the Internet?'"
--Mike Godwin, Electronic Frontier Foundation


-----Original Message-----
From: linux-kernel-owner@xxxxxxxxxxxxxxx
[mailto:linux-kernel-owner@xxxxxxxxxxxxxxx] On Behalf Of Paul Rolland
Sent: Monday, February 12, 2007 12:19 PM
To: 'Tejun Heo'
Cc: 'Alan'; 'Robert Hancock'; 'Linux Kernel Mailing List'
Subject: RE: AHCI - remove probing of ata2

Hello Tejun,

You have a Maxtor connected to that port, right? That's caused by

Waoh, you are using crystal ball ? :) You are right, this is a Maxtor
disk, 250 MB. If you want more details about this disk, I can send you
a complete details.

firmware bug. Future kernels will consider that condition as
protocol
violation and blacklist the drive such that NCQ is not used
on it. I
think it can be dangerous on rare corner/error cases but
there hasn't
been any actual report of problems caused by that, so no need
to worry
about it too much. If it bothers you, you can turn NCQ off
using sysfs
node. Take a look at FAQ section of http://linux-ata.org

I'm just slightly worried about that, and because all this libata
stuff is quite "new", I prefer to report everything I can
see, considering
that I can test patches on this machine if people need me to do so.
So, consider this machine as some kind of playground if you have
some code you want someone to test.

Slightly OT, but it's generally a good idea to use LABELs to access
filesystems. With so many ports and EH dynamics including
hotplug, it's
much more difficult to keep device names persistent and
remember them.

Yes, that's what I should do, but I've never really like that stuff ;(

So, 2.6.20-rc7 results are :
- ata2 probing still very long and delaying boot a lot,

That's sil4726's config device acting weird. When reset as
a normal
device (not PMP device), sil4726 acts as a normal ATA
device which is
used to configure how the chip behaves. Unfortunately, the
emulation
seems to contain some flaws and cause lots of delays as
you've seen.
I'm attaching a patch to clear TF before IDENTIFY which
fixes similar
IDENTIFY failures on buggy ATAPI devices.

OK, will try this tonite (I'm sorry, this is my home comp.,
and I'm at the
office right now - will tell you tomorrow).

- Jmicron PATA still not working, and doesn't even detect
the DVD-ROM on
the port.

This problem is likely to be fixed by clearing TF before IDENTIFY.

So, please test the attached patch and report the result.

Will do, and will test more if you more that are to be tested !

BTW, maybe OT, but what about setting a list of people willing to test
patches together with their configurations so that they can be send
patches related to their hardware ? That could be useful to
people developing
drivers...

Regards,
Paul

-
To unsubscribe from this list: send the line "unsubscribe
linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Attachment: data.tar.bz2
Description: Binary data

Relevant Pages

  • Re: Quit again. This time...for good. Help please!
    ... Congratulations on almost 2 weeks done! ... not worry too much about the patches, ... I can always stick a patch on my or chew a ...
    (alt.support.stop-smoking)
  • Re: [PATCH] fix race in AF_UNIX
    ... Don't worry, I only expect you to make the situation worse :-) ... I'll try to find some time to look more at your patch. ... If nobody else wants to review your ... and people will enjoy reviewing your patches that much more. ...
    (Linux-Kernel)
  • 9_Recommended error codes (specifically return code 5)
    ... * "return code 2" indicates patches are already installed. ... * "return code 25" means a patches requires another patch that is not yet installed. ... With or without using the save option, the patch installation process ... Installing 114008-01... ...
    (SunManagers)
  • Re: [PATCH] ext4: memory leakage in ext4_mb_init()
    ... one of the important parts of a patch is that the patcher ... If you are not able to deal with all patches received, ... stock kernel, is buggy, and end users have to face panic. ... Ext4 is actually quite stable at this point. ...
    (Linux-Kernel)
  • Re: This is [Re:] How to improve the quality of the kernel[?].
    ... The -mm kernel already implements what your proposed PTS would do. ... If patch have no TS ID, ... Thus i can apply for example lguest patches and implement and test new ... How many open source projects use Bugzilla and how many use the Debian BTS? ...
    (Linux-Kernel)