Re: somebody dropped a (warning) bomb

"Pekka Enberg" <penberg@xxxxxxxxxxxxxx> writes:
On 2/13/07, Sergei Organov <osv@xxxxxxxxx> wrote:
With almost any warning out there one makes more or less efforts to
suppress the warning where it gives false positives, isn't it?

Yes, as long it's the _compiler_ that's doing the effort.
You shouldn't need to annotate the source just to make the compiler
shut up.

Sorry, what do you do with "variable 'xxx' might be used uninitialized"
warning when it's false? Turn it off? Annotate the source? Assign fake
initialization value? Change the compiler so that it does "the effort"
for you? Never encountered false positive from this warning?

Once the compiler starts issuing enough false positives, it's
time to turn off that warning completely.

Yes, I don't argue that. I said "otherwise the warning is more or less
sucks", and then it's up to programmers to decide if it's enough sucks
to be turned off. The decision depends on the importance of its true
positives then. Only if warning never has true positives it is
unconditional, total, unhelpful crap, -- that was my point.

Therefore, the only sane strategy for a warning is to aim for zero
false positives.

Sure. But unfortunately this in an unreachable aim in most cases.

-- Sergei.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Relevant Pages

  • [PATCH] kbuild: get rid of false positives in section mismatch warnings
    ... Following patch committed to my kbuild tree and pushed out. ... There is still a way to go before we are warning free... ... Following patch introduce a whitelist to 'false positives' are not warned of. ... * this pattern. ...
    (Linux-Kernel)
  • Re: somebody dropped a (warning) bomb
    ... shouldn't need to annotate the source just to make the compiler shut ... Once the compiler starts issuing enough false positives, ... to turn off that warning completely. ...
    (Linux-Kernel)
  • RE: Chkrootkit anomaly
    ... >You have 1 process hidden for readdir command ... >Warning: Possible LKM Trojan installed ... >These messages will appear only on the odd occasion, ... >False positives or very crafty rootkit? ...
    (freebsd-questions)
  • Re: kref refcnt and false positives
    ... kref refcnt and false positives ... I started seeing following WARNING on CPU offline followed by online on my ...
    (Linux-Kernel)
  • Re: Why INFINITE loop in a thread occupy so much CPU time??
    ... With the attendant warning about the constant expression. ... This is a common programming technique. ... Good programming practice would consist of using the compiler at ... One can write 'bool' in C++ but not C. ...
    (microsoft.public.vc.mfc)