Re: [patch 07/21] Xen-paravirt: remove ctor for pgd cache
- From: Jeremy Fitzhardinge <jeremy@xxxxxxxx>
- Date: Fri, 16 Feb 2007 15:33:09 -0800
Christoph Lameter wrote:
On Thu, 15 Feb 2007, Jeremy Fitzhardinge wrote:It's true I wrote this patch as a result of accidentally reading slob.c
Remove the ctor for the pgd cache. There's no point in having the
cache machinery do this via an indirect call when all pgd are freed in
the one place anyway.
Great. We finally get rid of this evil .....
On second throughts:
Are you sure that you understand what you are modifying? The ctor is not
called when you allocate an object but when the slab allocates it. Freeing
an object does not make the slab free it. It will hold it for the next
kmalloc. So you may just have reduced performance somewhat by addiung
additional ctor processing and possibly disturbed the preservation of
cache hot pgds.
rather than slab.c, which was mostly as a result of hopeful thinking (I
knew that there has been discussion about removing all the slab cache
stuff, and I assumed that it had already happened). As a result I'm
withdrawing this patch for now, but with any luck it will be useful at
some point.
J
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
- References:
- [patch 00/21] Xen-paravirt: Xen guest implementation for paravirt_ops interface
- From: Jeremy Fitzhardinge
- [patch 07/21] Xen-paravirt: remove ctor for pgd cache
- From: Jeremy Fitzhardinge
- Re: [patch 07/21] Xen-paravirt: remove ctor for pgd cache
- From: Christoph Lameter
- [patch 00/21] Xen-paravirt: Xen guest implementation for paravirt_ops interface
- Prev by Date: Re: [Xen-devel] Re: [patch 12/21] Xen-paravirt: Allocate and free vmalloc areas
- Next by Date: Re: O2micro smartcard reader driver.
- Previous by thread: Re: [patch 07/21] Xen-paravirt: remove ctor for pgd cache
- Next by thread: [patch 08/21] Xen-paravirt: Allow paravirt backend to choose kernel PMD sharing
- Index(es):
Relevant Pages
|
