Re: [PATCH 2.6.21-rc1] ibmebus: Use of_device_uevent()

Hoang-Nam Nguyen wrote:
This patch replaces ibmebus_uevent() by Sylvain's generic function.

struct bus_type ibmebus_bus_type = {
- .name = "ibmebus",
- .uevent = ibmebus_uevent,
- .match = ibmebus_bus_match,
+ .name = "ibmebus",
+ .uevent = of_device_uevent,
+ .match = ibmebus_bus_match,
};
EXPORT_SYMBOL(ibmebus_bus_type);

Doesn't that oops when called with the fake parent device ?

Either you do a wrapper that test for it (that's what I did when I
posted the patch).
Or, an even better approach is to add this

+ if (!ebus_dev->ofdev.node)
+ return -ENODEV;

inside the code of of_device_uevent itself.


Sylvain



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/