Re: [PATCH 1/2] Define FIXED_PORT flag for serial_core



On Tue, 20 Feb 2007 14:19:51 +1100 (EST)
David Gibson <david@xxxxxxxxxxxxxxxxxxxxx> wrote:

At present, the serial core always allows setserial in userspace to
change the port address, irq and base clock of any serial port. That
makes sense for legacy ISA ports, but not for (say) embedded ns16550
compatible serial ports at peculiar addresses. In these cases, the
kernel code configuring the ports must know exactly where they are,
and their clocking arrangements (which can be unusual on embedded
boards). It doesn't make sense for userspace to change these
settings.

Therefore, this patch defines a UPF_FIXED_PORT flag for the uart_port
structure. If this flag is set when the serial port is configured,
any attempts to alter the port's type, io address, irq or base clock
with setserial are ignored.

In addition this patch uses the new flag for on-chip serial ports
probed in arch/powerpc/kernel/legacy_serial.c, and for other
hard-wired serial ports probed by drivers/serial/of_serial.c.

Signed-off-by: David Gibson <dwg@xxxxxxxxxxx>

Acked-by: Alan Cox <alan@xxxxxxxxxx>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



Relevant Pages

  • Re: [PATCH 1/2] Define FIXED_PORT flag for serial_core
    ... If this flag is set when the serial port is configured, ... any attempts to alter the port's type, io address, irq or base clock ... modules external to the 8250 driver itself, such as PCI, PNP, etc. ...
    (Linux-Kernel)
  • Re: [PATCH 1/2] Define FIXED_PORT flag for serial_core
    ... If this flag is set when the serial port is configured, ... any attempts to alter the port's type, io address, irq or base clock ... modules external to the 8250 driver itself, such as PCI, PNP, etc. ...
    (Linux-Kernel)
  • Re: [PATCH 1/2] Define FIXED_PORT flag for serial_core
    ... If this flag is set when the serial port is configured, ... any attempts to alter the port's type, io address, irq or base clock ... IOW, we apply this "fixed port" to any port registered by probe ... modules external to the 8250 driver itself, such as PCI, PNP, etc. ...
    (Linux-Kernel)
  • Re: [PATCH 1/2] Define FIXED_PORT flag for serial_core
    ... If this flag is set when the serial port is configured, ... any attempts to alter the port's type, io address, irq or base clock ... IOW, we apply this "fixed port" to any port registered by probe ... modules external to the 8250 driver itself, such as PCI, PNP, etc. ...
    (Linux-Kernel)
  • [PATCH 1/2] Define FIXED_PORT flag for serial_core
    ... change the port address, irq and base clock of any serial port. ...
    (Linux-Kernel)