Re: [PATCH 2.6.20] kobject net ifindex + rename

Hi,

Patch for 2.6.20 is attached.

... and in the meantime netdevices aren't class_device any more :) IOW,
your patch isn't going to work any more. Also, I think wireless could
benefit from this as well.

The kobject framework is well designed, so adding these
features is trivial change and won't run the risk of breaking anything
(famous last words). Obviously, hotplug apps are free to ignore those
additional features.

Why not just add this to base kobject_rename instead? That way,
userspace is notified for all renames in sysfs.
The patch then collapses down to the change in net's sysfs code to add
the ifindex to the environment, and another change in kobject to invoke
a new event when a name changes and show the old name.

johannes

Attachment: signature.asc
Description: This is a digitally signed message part

Relevant Pages

  • Re: [PATCH 2.6.20] kobject net ifindex + rename
    ... Wireless interface are regular netdevices. ... features is trivial change and won't run the risk of breaking anything ... The patch then collapses down to the change in net's sysfs code to add ...
    (Linux-Kernel)
  • Re: PostgreSQL pgbench performance regression in 2.6.23+
    ... Also, that requires being intrusive into people's setup scripts, which bothers me a lot more than doing a bit of kernel tuning at system startup. ... I did again get useful results here with the stock 2.6.26.git kernel and default parameters using Peter's small patch to adjust se.waker. ... Combining those two but keeping the rest of the features on actually gave the best result I've ever seen here, better than with all the features disabled. ... Mike suggested a patch to 2.6.25 in this thread that backports the feature for disabling SCHED_FEAT_SYNC_WAKEUPS. ...
    (Linux-Kernel)
  • Re: kgdb support in vanilla 2.6.2
    ... There are a few features in the patch in -mm which I am not ... The timestamping I added at a time when the alternative that was suggested was ... send the line "unsubscribe linux-kernel" in ...
    (Linux-Kernel)
  • KB958644 keeps kicking me off line.
    ... Is anyone else having trouble with XP's latest critical service patch, ... On my wireless laptop last night, a Dell 1505 running XP media SP3, as soon ... broken up connection that lasted a minute or so, ... I tried rebooting several times and never got on again. ...
    (microsoft.public.windowsupdate)
  • [patch] Re: PostgreSQL pgbench performance regression in 2.6.23+
    ... better than with all the features disabled. ... Because those were git _with_ Peter's patch. ... feature for disabling SCHED_FEAT_SYNC_WAKEUPS. ... handler (int n) ...
    (Linux-Kernel)