Re: [GIT PATCH] HID and USB HID update for 2.6.21-rc2

From: Jiri Kosina <jkosina@xxxxxxx>
Date: Wed, 28 Feb 2007 18:41:53 +0100 (CET)

On Wed, 28 Feb 2007, Linus Torvalds wrote:

There is no excuse for putting a large array in a header file and
including it millions of times. Or even just twice. The point of a
header file is to *declare* things, not to have big data structures in.

The point was that noone else than hid/hid-core.c would ever be going to
include this header with blacklist. The blacklist is growing in time quite
rapidly and having it in the middle of the code just didn't look pretty -
currently you have to perform some scrolling effort just to skip from
usbhid_init_reports() to hid_find_max_report(), which just looks very sad
to me.

But OK, I will leave it in there.

--
Jiri Kosina
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Follow-Ups:
- Re: [GIT PATCH] HID and USB HID update for 2.6.21-rc2
  - From: Linus Torvalds

References:
- [GIT PATCH] HID and USB HID update for 2.6.21-rc2
  - From: Jiri Kosina
- Re: [GIT PATCH] HID and USB HID update for 2.6.21-rc2
  - From: Linus Torvalds
- Re: [GIT PATCH] HID and USB HID update for 2.6.21-rc2
  - From: Jiri Kosina
- Re: [GIT PATCH] HID and USB HID update for 2.6.21-rc2
  - From: Linus Torvalds

Prev by Date: [PATCH 1/2] ehea: dynamic add / remove port
Next by Date: Re: lanana: Add major/minor entries for PPC QE UART devices
Previous by thread: Re: [GIT PATCH] HID and USB HID update for 2.6.21-rc2
Next by thread: Re: [GIT PATCH] HID and USB HID update for 2.6.21-rc2
Index(es):
- Date
- Thread

Relevant Pages

Re: make general windows module
... The VB version of these declarations is the "Declare Statement". ... mimicing
the behavior of a "windows.h" header file for VB. ... not all Windows API calls
can be called from VB as some use reference ... (microsoft.public.vb.general.discussion)
Re: confused about extern use
... going to achieve by declaring it as extern in the header file a.h. ...
composed on one or more compilation units. ... Essentially you *declare* the type
wherever it is ... (comp.lang.c)
Re-forward declaration of types which were already forward declared
... Is it a good style to re-forward declare the types, ... forward declared in
base header file, in derived class header file? ... (comp.lang.cpp)
Re-exporting functions from dynamically linked DLL
... I have a 3rd party DLL which does not include a LIB file, just a header file ...
with typedef declarations for exported functions (It is intended for dynamic ... #define
DllExport __declspec ... but I would prefer to just declare it as exported somehow.
... (microsoft.public.vc.mfc)
Re: error LNK2005
... variables in the header file; consequently, each module which includes it gets a new,
... Declare the variable once, in the .cpp file associated with the .h file. ...
extern in the header file. ... complain but all the other files claim that my arrays
are already ... (microsoft.public.vc.mfc)