Re: [GIT PATCH] HID and USB HID update for 2.6.21-rc2



On Wed, 28 Feb 2007, Jiri Kosina wrote:

On Wed, 28 Feb 2007, Linus Torvalds wrote:

There is no excuse for putting a large array in a header file and
including it millions of times. Or even just twice. The point of a
header file is to *declare* things, not to have big data structures in.

The point was that noone else than hid/hid-core.c would ever be going to
include this header with blacklist.

So:
- clearly other people *do* include it.
- if no-one else incldues it WHY HAVE IT SEPARATE!
- if you want to have it separate for other reasons, YOU MAKE IT A .c
FILE, SINCE IT'S CLEARLY NOT A HEADERFILE!

In other words, there is *zero* excuse for that braindamage.

But OK, I will leave it in there.

No. You need to realize just WHY it was wrong. Not just an "But OK".

Because if you don't see why I'm complaining, I can't pull from you. You
can send me patches, but for me to pull a git patch from you, I need to
know that you know what you're doing, and I need to be able to trust
things *without* then having to go and check every individual change by
hand.

If I have to check changes like this by hand, I want you to send patches
to the mailing list, so that other people can help me filter it out. It
really is that simple, and that fundamental. It's about code flow, and
it's about the fact that there's no way I can look at every change and vet
it for being sane.

I simply *cannot* do git-to-git merges with people I can't trust to have
good enough judgement that I don't need to do the micromanagement and
check everything myself. I can't afford to. I don't have the bandwidth,
but I also simply don't have the interest in micro-managing.

So people I do git merges with need to show that they have good taste and
skills, otherwise it needs to be done as open patches where *other* people
with good taste and skills can help me.

Linus


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Relevant Pages

  • Re: [V9fs-developer] [GIT PULL] 9p Patches for 2.6.23 merge window
    ... Moves the header files from fs/9p to include/net/9p and updates the ... Unfortunately the three patches were applied as a single one in Eric's ... the whole "keep code movement separate from changes" ...
    (Linux-Kernel)
  • Re: Qmail
    ... I had a number of issues with Qmail. ... with all the patches proved to be too much work. ... > problem 'Disallowed breakage found in header name - potential virus' found ... > To unsubscribe, ...
    (freebsd-isp)
  • Re: header files including other files
    ... Really I guess I am asking advice about source code organisation. ... Now, in any particular module, the module header file declares exported ... compile it with no errors. ...
    (comp.arch.embedded)
  • Re: [DRIVER SUBMISSION] DRBD wants to go mainline
    ... header file. ... and then include some header after that. ... I want to be able to do a rate-limit per specific message/code fragment, ... When I earlier said I thought I was in macro hell, well, I was ...
    (Linux-Kernel)
  • Re: "I want to ask about c++"
    ... This is called a "header include guard", or simply a "header guard". ... With very rare exceptions, you should not define an object in a header file, nor a non-static function. ... The reservations are restricted only because the second character of the identifier was a 'd'. ...
    (comp.lang.c.moderated)