Re: [PATCH 2.6.20] kobject net ifindex + rename

On Wed, Feb 28, 2007 at 10:16:05AM +0100, Johannes Berg wrote:
Hi,

Patch for 2.6.20 is attached.

... and in the meantime netdevices aren't class_device any more :) IOW,
your patch isn't going to work any more.

That's why I always specify the kernel version. I'll look into
that, I'm sure it's not the end of the world ;-)

Also, I think wireless could benefit from this as well.

In which sense ? Wireless interface are regular netdevices.

The kobject framework is well designed, so adding these
features is trivial change and won't run the risk of breaking anything
(famous last words). Obviously, hotplug apps are free to ignore those
additional features.

Why not just add this to base kobject_rename instead? That way,
userspace is notified for all renames in sysfs.
The patch then collapses down to the change in net's sysfs code to add
the ifindex to the environment, and another change in kobject to invoke
a new event when a name changes and show the old name.

I'm just trying to follow the established pattern. Both
class_device_add() and class_device_del() are generating the
event. Also, I'm not sure if other subsystem would benefit from it, I
don't want to generate too many useless events.

johannes

Thanks !

Jean

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Relevant Pages

  • Re: [PATCH 2.6.20] kobject net ifindex + rename
    ... Also, I think wireless could ... features is trivial change and won't run the risk of breaking anything ... The patch then collapses down to the change in net's sysfs code to add ...
    (Linux-Kernel)
  • Re: PostgreSQL pgbench performance regression in 2.6.23+
    ... Also, that requires being intrusive into people's setup scripts, which bothers me a lot more than doing a bit of kernel tuning at system startup. ... I did again get useful results here with the stock 2.6.26.git kernel and default parameters using Peter's small patch to adjust se.waker. ... Combining those two but keeping the rest of the features on actually gave the best result I've ever seen here, better than with all the features disabled. ... Mike suggested a patch to 2.6.25 in this thread that backports the feature for disabling SCHED_FEAT_SYNC_WAKEUPS. ...
    (Linux-Kernel)
  • Re: kgdb support in vanilla 2.6.2
    ... There are a few features in the patch in -mm which I am not ... The timestamping I added at a time when the alternative that was suggested was ... send the line "unsubscribe linux-kernel" in ...
    (Linux-Kernel)
  • [patch] Re: PostgreSQL pgbench performance regression in 2.6.23+
    ... better than with all the features disabled. ... Because those were git _with_ Peter's patch. ... feature for disabling SCHED_FEAT_SYNC_WAKEUPS. ... handler (int n) ...
    (Linux-Kernel)
  • Re: [PATCH 11/11] sysfs: user namespaces: fix bug with clone(CLONE_NEWUSER) with fairsched
    ... do the ida tagging as you suggested in your response to patch 6, ... should be no reference to the user_ns left in sysfs code. ...
    (Linux-Kernel)