Re: Problem with freezable workqueues

On Wednesday, 28 February 2007 20:32, Oleg Nesterov wrote:
On 02/28, Rafael J. Wysocki wrote:

--- workqueue.c.org 2007-02-28 18:32:48.000000000 +0530
+++ workqueue.c 2007-02-28 18:44:23.000000000 +0530
@@ -718,6 +718,8 @@ static void cleanup_workqueue_thread(str
insert_wq_barrier(cwq, &barr, 1);
cwq->should_stop = 1;
alive = 1;
+ if (frozen(cwq->thread))
+ thaw(cwq->thread);
}
spin_unlock_irq(&cwq->lock);

Unfortunately, the above code is mm-only. Is the analogous fix for 2.6.21-rc2
viable?

I am sorry, I lost track of this problem. As for 2.6.21, create_freezeable_workqueue
doesn't work and conflict with suspend. Why can't we remove it from XFS as you
suggested before?

Yes, we can (preparing a patch). I was just curious. :-)

Rafael
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Relevant Pages