Re: Problem with freezable workqueues

On 02/28, Rafael J. Wysocki wrote:

Okay, but I've just finished the patch that removes the freezability of
workqueues (appended), so can we please do this in a separate one?

Please, please, no. This patch is of course correct, but it breaks _a lot_
of patches in -mm tree.

May I ask you to send just

===================================================================
--- linux-2.6.21-rc2.orig/fs/xfs/linux-2.6/xfs_buf.c
+++ linux-2.6.21-rc2/fs/xfs/linux-2.6/xfs_buf.c
@@ -1829,11 +1829,11 @@ xfs_buf_init(void)
if (!xfs_buf_zone)
goto out_free_trace_buf;

- xfslogd_workqueue = create_freezeable_workqueue("xfslogd");
+ xfslogd_workqueue = create_workqueue("xfslogd");
if (!xfslogd_workqueue)
goto out_free_buf_zone;

- xfsdatad_workqueue = create_freezeable_workqueue("xfsdatad");
+ xfsdatad_workqueue = create_workqueue("xfsdatad");
if (!xfsdatad_workqueue)
goto out_destroy_xfslogd_workqueue;



this bit?

After that, we can do the "removes the freezability of workqueues" patch
against -mm tree.

Oleg.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Relevant Pages

  • Re: Problem with freezable workqueues
    ... This patch is of course correct, ... we can do the "removes the freezability of workqueues" patch ... Okay, if that's better. ...
    (Linux-Kernel)
  • Re: Problem with freezable workqueues
    ... This patch is of course correct, ... we can do the "removes the freezability of workqueues" patch ... Okay, if that's better. ...
    (Linux-Kernel)
  • Success! was Re: tvtime audio vs pcHDTV-3000 card and pvHDTV-1.6 software
    ... On Wednesday 16 March 2005 20:15, Gene Heskett wrote: ... > that a diff actually outputs only the src code differences, ... nor in that simple little 10 line patch that ... >Unforch, the 2.6.11 plain tree has not, in this case been built yet ...
    (Linux-Kernel)
  • [GIT PATCH] USB bugfixes for 2.6.12-rc3
    ... Here are a number of USB bugfixes for 2.6.12-rc3. ... tree 72abe7e0dd4b4135ca8b2d6f4e7cb81bd173a437 ... parent f3fae6ed6aafe71826e03876ad3d4e1d3f238ec8 ... This patch recognizes that pseudo-class by the GUIDs in those descriptors, ...
    (Linux-Kernel)
  • [PATCH 0/4] VFS: Enable future NFS superblock sharing [try #3]
    ... A patch to pass the vfsmount record through to the get_sbop, ... the vfsmount root doesn't have to be the superblock root. ... Ideally we'd represent each FSID tree retrieved from the server as a single ...
    (Linux-Kernel)