[PATCH] worker_thread: don't play with signals



worker_thread() doesn't need to "Block and flush all signals", this was already
done by its caller, kthread().

Signed-off-by: Oleg Nesterov <oleg@xxxxxxxxxx>

--- 6.20-rc6-mm3/kernel/workqueue.c~signals 2007-02-20 02:21:11.000000000 +0300
+++ 6.20-rc6-mm3/kernel/workqueue.c 2007-02-28 23:58:11.000000000 +0300
@@ -290,18 +290,11 @@ static int worker_thread(void *__cwq)
struct cpu_workqueue_struct *cwq = __cwq;
DEFINE_WAIT(wait);
struct k_sigaction sa;
- sigset_t blocked;

if (!cwq->wq->freezeable)
current->flags |= PF_NOFREEZE;

set_user_nice(current, -5);
-
- /* Block and flush all signals */
- sigfillset(&blocked);
- sigprocmask(SIG_BLOCK, &blocked, NULL);
- flush_signals(current);
-
/*
* We inherited MPOL_INTERLEAVE from the booting kernel.
* Set MPOL_DEFAULT to insure node local allocations.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



Relevant Pages

  • [PATCH] utrace: remove indirections
    ... With utrace as the new singing dancing ... typedef struct utrace_get { ... * Called with the siglock held before dequeuing pending signals. ... * from seeing its child in TASK_STOPPED state when it waits with WSTOPPED. ...
    (Linux-Kernel)
  • [PATCH v4 03/15] PCI: prevent duplicate slot names
    ... We now rename these duplicate slots on behalf of the user. ... If firmware assigns the name N to multiple slots, ... struct pci_bus of parent bridge ... the caller may pass -1 for @slot_nr. ...
    (Linux-Kernel)
  • [PATCH v3 02/14] PCI: prevent duplicate slot names
    ... We now rename these duplicate slots on behalf of the user. ... If firmware assigns the name N to multiple slots, ... struct pci_bus of parent bridge ... the caller may pass -1 for @slot_nr. ...
    (Linux-Kernel)
  • [RFC 16/17] microblaze: clean up signal handling
    ... * SA_RESTART flag to get restarting signals ... * SA_NODEFER prevents the current signal from being masked in the handler. ... -typedef struct sigaltstack { ... -asmlinkage int ...
    (Linux-Kernel)

  • ... * SA_RESTART flag to get restarting signals ... * SA_NODEFER prevents the current signal from being masked in the handler. ... -typedef struct sigaltstack { ... -asmlinkage int ...
    (Linux-Kernel)