Re: Problem with freezable workqueues
- From: Pavel Machek <pavel@xxxxxx>
- Date: Wed, 28 Feb 2007 23:44:43 +0100
On Wed 2007-02-28 23:39:30, Rafael J. Wysocki wrote:
On Wednesday, 28 February 2007 21:35, Oleg Nesterov wrote:
On 02/28, Rafael J. Wysocki wrote:
Okay, but I've just finished the patch that removes the freezability of
workqueues (appended), so can we please do this in a separate one?
Please, please, no. This patch is of course correct, but it breaks _a lot_
of patches in -mm tree.
May I ask you to send just
===================================================================
--- linux-2.6.21-rc2.orig/fs/xfs/linux-2.6/xfs_buf.c
+++ linux-2.6.21-rc2/fs/xfs/linux-2.6/xfs_buf.c
@@ -1829,11 +1829,11 @@ xfs_buf_init(void)
if (!xfs_buf_zone)
goto out_free_trace_buf;
- xfslogd_workqueue = create_freezeable_workqueue("xfslogd");
+ xfslogd_workqueue = create_workqueue("xfslogd");
if (!xfslogd_workqueue)
goto out_free_buf_zone;
- xfsdatad_workqueue = create_freezeable_workqueue("xfsdatad");
+ xfsdatad_workqueue = create_workqueue("xfsdatad");
if (!xfsdatad_workqueue)
goto out_destroy_xfslogd_workqueue;
this bit?
After that, we can do the "removes the freezability of workqueues" patch
against -mm tree.
Okay, if that's better.
Pavel, is that acceptable to you?
No problem, but get that acked-by: from XFS people ;-).
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
- References:
- Problem with freezable workqueues
- From: Rafael J. Wysocki
- Re: Problem with freezable workqueues
- From: Rafael J. Wysocki
- Re: Problem with freezable workqueues
- From: Oleg Nesterov
- Re: Problem with freezable workqueues
- From: Rafael J. Wysocki
- Problem with freezable workqueues
- Prev by Date: Need pci=assign-busses for Acer Aspire 9410
- Next by Date: Re: lanana: Add major/minor entries for PPC QE UART devices
- Previous by thread: Re: Problem with freezable workqueues
- Next by thread: Re: Problem with freezable workqueues
- Index(es):
Relevant Pages
|
