Re: [PATCH 1/2] mv643xx_eth: move mac_addr inside of mv643xx_eth_platform_data
- From: "Dale Farnsworth" <dale@xxxxxxxxxxxxxx>
- Date: Wed, 28 Feb 2007 16:40:23 -0700
On Wed, Feb 28, 2007 at 03:11:03PM -0800, Stephen Hemminger wrote:
On Wed, 28 Feb 2007 15:40:31 -0700
"Dale Farnsworth" <dale@xxxxxxxxxxxxxx> wrote:
The information contained within platform_data should be self-contained.
Replace the pointer to a MAC address with the actual MAC address in
struct mv643xx_eth_platform_data.
Signed-off-by: Dale Farnsworth <dale@xxxxxxxxxxxxxx>
Index: b/drivers/net/mv643xx_eth.c
===================================================================
--- a/drivers/net/mv643xx_eth.c
+++ b/drivers/net/mv643xx_eth.c
@@ -1380,7 +1380,9 @@ static int mv643xx_eth_probe(struct plat
pd = pdev->dev.platform_data;
if (pd) {
- if (pd->mac_addr)
+ static u8 zero_mac_addr[6] = { 0 };
+
+ if (memcmp(pd->mac_addr, zero_mac_addr, 6) != 0)
memcpy(dev->dev_addr, pd->mac_addr, 6);
is_zero_ether_addr() is faster/cleaner for this
Thanks. I follow up with a modified patch in a day or two.
-Dale
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
- References:
- Re: [PATCH 1/2] mv643xx_eth: move mac_addr inside of mv643xx_eth_platform_data
- From: Stephen Hemminger
- Re: [PATCH 1/2] mv643xx_eth: move mac_addr inside of mv643xx_eth_platform_data
- Prev by Date: Re: Wanted: simple, safe x86 stack overflow detection
- Next by Date: Re: PID entries in /proc sorted by number, not start time in 2.6.19
- Previous by thread: Re: [PATCH 1/2] mv643xx_eth: move mac_addr inside of mv643xx_eth_platform_data
- Next by thread: Re: Wanted: simple, safe x86 stack overflow detection
- Index(es):
Relevant Pages
|
|
