Re: [PATCH] pata_sil680 suspend/resume

Tejun,

I tracked this change down to your patch:
http://marc.theaimsgroup.com/?t=115012763500002&r=1&w=2 (approximately).
(Interestingly, Jeff submitted the respective cumulative libata patch last
year on my birthday:-( ) Also, there's a Ubuntu bug report:
https://launchpad.net/ubuntu/+source/linux-source-2.6.20/+bug/76431
identical to what I see, although I cannot check if it worked before
2.6.20. Could you, please, comment how is this supposed to work? In
particular, what shoud trigger the EH action, leading to setting the
ATA_DFLAG_SUSPENDED flag? Below again my earlier post for reference.

Thanks
Guennadi

On Wed, 28 Feb 2007, Guennadi Liakhovetski wrote:

On Mon, 26 Feb 2007, Guennadi Liakhovetski wrote:

With a post 2.6.20 kernel from powerpc.git I cannot suspend at all:

pata_sil680 0000:00:0c.0: suspend
ata1: suspend failed, device 0 still active
pci_device_suspend(): ata_pci_device_suspend+0x0/0x74() returns -16
suspend_device(): pci_device_suspend+0x0/0xac() returns -16
Could not suspend device 0000:00:0c.0: error -16

AFAICS, "still active" is printed from ata_host_suspend() if a device
(disk) on the host to be suspended doesn't have ATA_DFLAG_SUSPENDED flag
set. This flag is only set in ata_eh_suspend(), which is only called from
ata_eh_recover(), like this:

generic_error_handler()
ata_bmdma_drive_eh()
ata_do_eh()
ata_eh_recover()
ata_eh_suspend()
dev->flags |= ATA_DFLAG_SUSPENDED;

but I don't understand why the error handler should be envoked? Should the
"disk" be suspended before the host and is it when the eh should set the
flag? If my guess is right - why doesn't the disk get suspended on my
machine? Shall I suspend it explicitely from userspace? I do "hdparm -Y",
and it does stop spinning", but I still get the error.

Thanks
Guennadi
---
Guennadi Liakhovetski


---
Guennadi Liakhovetski
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Relevant Pages

  • Re: [PATCH] pata_sil680 suspend/resume
    ... This flag is only set in ata_eh_suspend, ... "disk" be suspended before the host and is it when the eh should set the ... Shall I suspend it explicitely from userspace? ...
    (Linux-Kernel)
  • Security problems with Dell Latitude C800 Notebook BIOSes
    ... Waited 3 BIOS revisions, this problem has still not been addressed, so ... When using suspend to disk, the Latitude BIOS dumps the system status to ... so it'll restore the session as expected. ...
    (Bugtraq)
  • Re: [RFD] Automatic suspend
    ... a disk driver might think it's appropriate to spin down ... the question is what criteria would the overall system monitor use to make ... the decision to trigger automatic suspend has to be based on some ... The activity from this background task shouldn't prevent an auto-sleep. ...
    (Linux-Kernel)
  • Re: SendMessage (in secondary thread) freezes application GUI thre
    ... power left, the application stopped hanging... ... Then, in the non-UI thread, check the flag. ... queue and, again, the third thread will process that. ... will probably suspend before the about-to-suspend message gets to the UI ...
    (microsoft.public.windowsce.app.development)
  • SB600 AHCI: Hard Disk Corruption
    ... (->SB600 AHCI controller), SAMSUNG HD501LJ SATA Disk. ... want suspend to ram to work first. ... "file not fonund", kernel reports ...
    (Linux-Kernel)