Re: [kvm-devel] [PATCH] KVM: MMU: Fix host memory corruption on i386 with >= 4GB ram
- From: Ingo Molnar <mingo@xxxxxxx>
- Date: Sun, 11 Mar 2007 11:33:34 +0100
* Avi Kivity <avi@xxxxxxxxxxxx> wrote:
PAGE_MASK is an unsigned long, so using it to mask physical addresses
on i386 (which are 64-bit wide) leads to truncation. This can result
in page->private of unrelated memory pages being modified, with
disasterous results.
Fix by not using PAGE_MASK for physical addresses; instead calculate
the correct value directly from PAGE_SIZE. Also fix a similar
BUG_ON().
Signed-off-by: Avi Kivity <avi@xxxxxxxxxxxx>
i have tested this, albeit with less than 4GB RAM.
Acked-by: Ingo Molnar <mingo@xxxxxxx>
Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
- References:
- [PATCH 0/2] KVM: More fixes for 2.6.21-rc3
- From: Avi Kivity
- [PATCH] KVM: MMU: Fix host memory corruption on i386 with >= 4GB ram
- From: Avi Kivity
- [PATCH 0/2] KVM: More fixes for 2.6.21-rc3
- Prev by Date: [RFC][PATCH 2/3] swsusp: Do not use page flags
- Next by Date: [PATCH] drivers/isdn/hardware/eicon/: remove unused header files
- Previous by thread: [PATCH] KVM: MMU: Fix host memory corruption on i386 with >= 4GB ram
- Next by thread: [PATCH] KVM: MMU: Fix guest writes to nonpae pde
- Index(es):
Relevant Pages
|