Re: [PATCH 4/5] AF_RXRPC: Key facility changes for AF_RXRPC [try #2]
- From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
- Date: Fri, 16 Mar 2007 13:38:24 +0000
On Fri, Mar 16, 2007 at 12:50:31PM +0000, David Howells wrote:
Export the keyring key type definition.
Add extra alternative types into the key's type_data union to make it more
useful.
You wrote the code so there must be some reason for this, but these
changes look rather odd to me :)
diff --git a/security/keys/keyring.c b/security/keys/keyring.c
index ad45ce7..88292e3 100644
--- a/security/keys/keyring.c
+++ b/security/keys/keyring.c
@@ -66,6 +66,8 @@ struct key_type key_type_keyring = {
.read = keyring_read,
};
+EXPORT_SYMBOL(key_type_keyring);
+
Having a type exported is really odd, how is this supposed to be a public API?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
- References:
- [PATCH 0/5] [RFC] AF_RXRPC socket family implementation [try #2]
- From: David Howells
- [PATCH 4/5] AF_RXRPC: Key facility changes for AF_RXRPC [try #2]
- From: David Howells
- [PATCH 0/5] [RFC] AF_RXRPC socket family implementation [try #2]
- Prev by Date: Re: [PATCH 2/5] AF_RXRPC: Move generic skbuff stuff from XFRM code to generic code [try #2]
- Next by Date: Re: [PATCH 0/5] [RFC] AF_RXRPC socket family implementation [try #2]
- Previous by thread: [PATCH 4/5] AF_RXRPC: Key facility changes for AF_RXRPC [try #2]
- Next by thread: Re: [PATCH 4/5] AF_RXRPC: Key facility changes for AF_RXRPC [try #2]
- Index(es):
Relevant Pages
|
