Re: [git patches] net driver fixes

On Thu, 29 Mar 2007, Jeff Garzik wrote:

Guennadi Liakhovetski wrote:
Jeff, might be worth getting the sk_buff leak fix in ppp from
http://www.spinics.net/lists/netdev/msg27706.html in 2.6.21 too?

Don't know how important it is for stable. It was present in 2.6.18 too.

Can you resend the patch to me, please?

Easier for the system to apply than the URL...

Sure, attached below. I think, though, this patch is already in someone's
tree. Andrew has applied it to -mm under the name

ppp-dont-leak-an-sk_buff-on-interface-destruction.patch

but then dropped with the reasoning "This patch was dropped because it was
merged into mainline or a subsystem tree". So, maybe it is now in Samuel's
IrDA tree. Samuel?So, maybe all you have to do is to pull it from his
tree.

Thanks
Guennadi
---------------------------------
Guennadi Liakhovetski, Ph.D.
DSA Daten- und Systemtechnik GmbH
Pascalstr. 28
D-52076 Aachen
Germany

Don't leak an sk_buff on interface destruction.

Signed-off-by: G. Liakhovetski <gl@xxxxxxxxx>

--- a/drivers/net/ppp_generic.c 2007-03-23 13:04:04.000000000 +0100
+++ b/drivers/net/ppp_generic.c 2007-03-23 13:05:29.000000000 +0100
@@ -2544,6 +2544,9 @@
ppp->active_filter = NULL;
#endif /* CONFIG_PPP_FILTER */

+ if (ppp->xmit_pending)
+ kfree_skb(ppp->xmit_pending);
+
kfree(ppp);
}

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Relevant Pages

  • Success! was Re: tvtime audio vs pcHDTV-3000 card and pvHDTV-1.6 software
    ... On Wednesday 16 March 2005 20:15, Gene Heskett wrote: ... > that a diff actually outputs only the src code differences, ... nor in that simple little 10 line patch that ... >Unforch, the 2.6.11 plain tree has not, in this case been built yet ...
    (Linux-Kernel)
  • [GIT PATCH] USB bugfixes for 2.6.12-rc3
    ... Here are a number of USB bugfixes for 2.6.12-rc3. ... tree 72abe7e0dd4b4135ca8b2d6f4e7cb81bd173a437 ... parent f3fae6ed6aafe71826e03876ad3d4e1d3f238ec8 ... This patch recognizes that pseudo-class by the GUIDs in those descriptors, ...
    (Linux-Kernel)
  • Re: [3/6] kgdb: core
    ... observations and updated the kgdb.git tree. ... Subject: [PATCH 2/8] pid, kgdb: add pid_max prototype ... Many architectures will select shadow-info support so having ...
    (Linux-Kernel)
  • Re: Please pull ACPI updates
    ... conflict resolution back into the original patch, ... The reason I maintain patches in quilt is that it's quite easy to ... their tree when my tree wasn't at exactly the same point. ... the originals. ...
    (Linux-Kernel)
  • [PATCH 0/4] VFS: Enable future NFS superblock sharing [try #3]
    ... A patch to pass the vfsmount record through to the get_sbop, ... the vfsmount root doesn't have to be the superblock root. ... Ideally we'd represent each FSID tree retrieved from the server as a single ...
    (Linux-Kernel)