Re: [RFC] pata_icside driver

On Mon, Apr 09, 2007 at 07:13:05AM -0400, Jeff Garzik wrote:
It should be noted, mainly for russell's benefit, that the ->irq_ack()
hook is only called if a debug define is manually enabled in libata.h,
in a single callsite.

The number of people that actually use the hook -- kernel hackers
debugging screaming interrupts -- can probably be counted on one hand.

Ok, in that case it makes sense for me to set this to ata_dummy_irq_ack
since I don't have any additional status registers specific to the
interface.

Presumably a similar change to pata_platform.c would be appropriate?

--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of:
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Relevant Pages

  • Re: trapping HSHELL_GETMINRECT in a shell hook
    ... My dev XP machine must have a hook installed ... I have my hooking code in a DLL and I install the hook with the ... Your hook procedure, which resides in a DLL, will be loaded into multiple ... it is capable of displaying debug output only for process you debug - ...
    (microsoft.public.win32.programmer.kernel)
  • Re: [RFC] pata_icside driver
    ... It should be noted, mainly for russell's benefit, that the ->irq_ackhook is only called if a debug define is manually enabled in libata.h, in a single callsite. ... Please read the FAQ at http://www.tux.org/lkml/ ...
    (Linux-Kernel)
  • Re: trapping HSHELL_GETMINRECT in a shell hook
    ... The SH_SHELL hook seemed to be the perfect solution, ... I have my hooking code in a DLL and I install the hook with the ... Your hook procedure, which resides in a DLL, will be loaded into multiple ... it is capable of displaying debug output only for process you debug - ...
    (microsoft.public.win32.programmer.kernel)
  • Detect if application is run from inside visual studio
    ... I am working on an application that installs a system wide keyboard ... I do not want to install this hook when I am running a debug ... build from inside the visual studio (or else it would hang the studio ... DEBUG symbol is defined. ...
    (microsoft.public.vsnet.debugging)
  • Re: trapping HSHELL_GETMINRECT in a shell hook
    ... This code shoud work unless there is another hook that does not call ... I have my hooking code in a DLL and I install the hook with the ... Your hook procedure, which resides in a DLL, will be loaded into multiple ... it is capable of displaying debug output only for process you debug - ...
    (microsoft.public.win32.programmer.kernel)