Re: [patch] CFS (Completely Fair Scheduler), v2



Ingo Molnar wrote:
this is the second release of the CFS (Completely Fair Scheduler) patchset, against v2.6.21-rc7:

http://redhat.com/~mingo/cfs-scheduler/sched-cfs-v2.patch

i'd like to thank everyone for the tremendous amount of feedback and testing the v1 patch got - i could hardly keep up with just reading the mails! Some of the stuff people addressed i couldnt implement yet, i mostly concentrated on bugs, regressions and debuggability.

Have you considered using rq->raw_weighted_load instead of rq->nr_running in calculating fair_clock? This would take the nice value (or RT priority) of the other tasks into account when determining what's fair.

Peter
PS You'd have to change the migration thread's load_weight from 0 to 1 in order to prevent divide by zero without having to explicitly check for it every time.
--
Peter Williams pwil3058@xxxxxxxxxxxxxx

"Learning, n. The kind of ignorance distinguishing the studious."
-- Ambrose Bierce
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



Relevant Pages

  • Re: [patch] CFS (Completely Fair Scheduler), v2
    ... patchset, against v2.6.21-rc7: ... i'd like to thank everyone for the tremendous amount of feedback and ... testing the v1 patch got - i could hardly keep up with just reading the ...
    (Linux-Kernel)
  • Re: [patch] CFS (Completely Fair Scheduler), v2
    ... i'd like to thank everyone for the tremendous amount of feedback and testing the v1 patch got - i could hardly keep up with just reading the mails! ... Would it be possible to publish changes relevant to the previous patch so that it's easier for us reviewers/critics to see the latest changes. ... E.g. if import such changes into something like quilt ) I can then use meld to follow what's going as suggestions get folded in and bugs get fixed etc. ...
    (Linux-Kernel)
  • Re: [RFC 0/3] Recursive reclaim (on __PF_MEMALLOC)
    ... at least enough to obtain the maximum memory resources ... Would peter's per bdi dirty page accounting patchset provide this? ... I've embraced Evgeniy's bio throttle patch on a 2.6.22.6 kernel ... MD+NBD mke2fs test not deadlock. ...
    (Linux-Kernel)
  • [PATCH 0/10] Time: Generic Timeofday Subsystem (v B15-mm)
    ... independent of the timer interrupt. ... behavior in cases of late or lost ticks, avoids interpolation errors, ... The patch set provides the minimal NTP changes, ... I've reworked this patchset so it builds and boots every step ...
    (Linux-Kernel)
  • Re: [patch 2/4] mempolicy: support optional mode flags
    ... time to review in detail. ... patchsets are currently outstanding that touch mempolicies. ... I based this entire patchset on your V3 contextualize_policypatch from ...
    (Linux-Kernel)