Re: Loud "pop" coming from hard drive on reboot

Mark Lord wrote:
Alan Cox wrote:
+ if (dev->needs_flush && ata_try_flush_cache(dev)) {
return ata_scsi_flush_xlat;
+ dev->needs_flush = 0;

Works better if you swap the dev-> and return lines

Heh, yeah, I noticed that!

Here it is, *tested* now, with another fix.

It would be nice if somebody who can hear the "pop" would also test this,
as it will confirm that this is a complete fix for the problem.

You'll probably be able to here the "pop" on sleep-to-disk.

My "pop" drives are busy elsewhere right now.

Tejun might use something like this, or do something better in libata-core,
but it's still helpful to have confirmation that we're on the right track.

Yeap, I was thinking about more conservative check but this looks simple
and sweet. :-)

--
tejun
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Relevant Pages

  • Re: RIP: Compuserve
    ... Yeah, way back when it was the only way to get on the interwebs. ... And windows didn't come preconfigured to be used with a modem, ... And it's not that hard to learn how to fix stuff either. ... "Freedom, true freedom, is nothing more than intellectual advantage over others." ...
    (alt.2600)
  • Re: Serious Missing Bandwidth
    ... It's not a tragedy if I find the reason, (and fix?) & it won't rank in my top ten datadrags. ... Yeah, I'd not be throwing any shit at me. ... Earned pride and knowledge? ... But a wanker like Timberwolf seems to 'advocate' dogma and I'm a dude with in need of a fix. ...
    (comp.sys.mac.advocacy)
  • Re: [Usability] "Finish" vs. "Close" in gnome-control-center dialogs
    ... Depending on what you mean by 'earlier versions', ... to 'fix' problems seen in user testing. ... strong bell with me--I had felt the exact same way about that dialog ... (Well tough shit boo hoo, I should get over it, yeah I ...
    (GNOME)
  • Re: Oops and Panics in 2.6.21.1, 2.6.20.6 and 2.6.19.2
    ... Yeah, ... great rewrite will fix this bug. ... In the big fat patchset, first I tried to fix it by removing ... I'll try to backport the synchronization fix but am afraid it can be too ...
    (Linux-Kernel)
  • Re: First piece?
    ... yeah, but those are signs of structure but not necessarily signs of ... Just repeating something doesn't mean its good ... I'm trying to fix that part now. ... little boring but I think thats easily fixed to some degree. ...
    (rec.music.theory)