[PATCH] Remove unnecessary irq disabling
- From: Glauber de Oliveira Costa <gcosta@xxxxxxxxxx>
- Date: Tue, 1 May 2007 18:30:50 -0300
RR asks us if it is really necessary to disable interrupts in
setup_secondary_APIC_clock(). The answer is no, since setup_APIC_timer()
starts by saving irq flags, which also disables them.
Signed-off-by: Glauber de Oliveira Costa <gcosta@xxxxxxxxxx>
--
Glauber de Oliveira Costa
Red Hat Inc.
"Free as in Freedom"
diff --git a/arch/x86_64/kernel/apic.c b/arch/x86_64/kernel/apic.c
index 124b2d2..7eacd5f 100644
--- a/arch/x86_64/kernel/apic.c
+++ b/arch/x86_64/kernel/apic.c
@@ -875,9 +875,7 @@ void __init setup_boot_APIC_clock (void)
void __cpuinit setup_secondary_APIC_clock(void)
{
- local_irq_disable(); /* FIXME: Do we need this? --RR */
setup_APIC_timer(calibration_result);
- local_irq_enable();
}
void disable_APIC_timer(void)
- Follow-Ups:
- Re: [PATCH] Remove unnecessary irq disabling
- From: Mark Lord
- Re: [PATCH] Remove unnecessary irq disabling
- Prev by Date: Re: Natsemi DP83815 driver spaming
- Next by Date: Re: Ext3 vs NTFS performance
- Previous by thread: [ANNOUNCE] Sparse 0.3 released
- Next by thread: Re: [PATCH] Remove unnecessary irq disabling
- Index(es):
Relevant Pages
|