Re: [PATCH] Remove unnecessary irq disabling
- From: Andi Kleen <ak@xxxxxxxxxx>
- Date: Wed, 2 May 2007 11:58:17 +0200
What does that break, or was it already broken and this fixes it?I think neither. This function is only called at early bootup,
(start_secondary() ), and most of its callees have interrupts off anyway.
But maybe we do lose something. Andi, do you have a word on this?
We need to enable them somewhere, but cpu_idle will do it in the end.
So it should be safe to drop it. I guess keeping them disabled the whole
time will be a little safer against potential races.
I added the patch, but might want some cooking in -mm first because this
is always fragile code.
-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
- Follow-Ups:
- Re: [PATCH] Remove unnecessary irq disabling
- From: Glauber de Oliveira Costa
- Re: [PATCH] Remove unnecessary irq disabling
- From: Mark Lord
- Re: [PATCH] Remove unnecessary irq disabling
- References:
- [PATCH] Remove unnecessary irq disabling
- From: Glauber de Oliveira Costa
- Re: [PATCH] Remove unnecessary irq disabling
- From: Mark Lord
- Re: [PATCH] Remove unnecessary irq disabling
- From: Glauber de Oliveira Costa
- [PATCH] Remove unnecessary irq disabling
- Prev by Date: Re: [PATCH] crypto: convert "crypto" subdirectory to UTF-8
- Next by Date: Re: [PATCH] crypto: convert "crypto" subdirectory to UTF-8
- Previous by thread: Re: [PATCH] Remove unnecessary irq disabling
- Next by thread: Re: [PATCH] Remove unnecessary irq disabling
- Index(es):
Relevant Pages
|