Re: [PATCH 2/3] UIO: Documentation

On Wed, 2 May 2007 10:41:35 +0200 Hans-Jürgen Koch wrote:

Am Mittwoch 02 Mai 2007 01:42 schrieb Randy Dunlap:

+<title>The Userspace I/O HOWTO</title>

Most of this reads well. Thanks.
A few typo corrections are below...

Thank you for your work. I generated a new patch that includes all your
suggestions and also fixes the build problems.

Hi,
What does your patch apply to, please? I get patch errors with it.


[...]

However, it still fails 'make htmldocs' for me.
What am I missing? How did it work for you?
My DTD doesn't like to see <varname> inside a <listitem>:


linux-2.6.21-rc7-mm2/Documentation/DocBook/uio-howto.xml:333: element listitem: validity error : Element listitem content does not follow the DTD, expecting (calloutlist | glosslist | itemizedlist | orderedlist | segmentedlist | simplelist | variablelist | caution | important | note | tip | warning | literallayout | programlisting | programlistingco | screen | screenco | screenshot | synopsis | cmdsynopsis | funcsynopsis | classsynopsis | fieldsynopsis | constructorsynopsis | destructorsynopsis | methodsynopsis | formalpara | para | simpara | address | blockquote | graphic | graphicco | mediaobject | mediaobjectco | informalequation | informalexample | informalfigure | informaltable | equation | example | figure | table | msgset | procedure | sidebar | qandaset | anchor | bridgehead | remark | highlights | abstract | authorblurb | epigraph | indexterm | beginpage)+, got (varname CDATA)


so I removed most of the <varname>s and still had errors.
Any suggestions?

Yes, this only occurs when the <listitem> content is not surrounded by
<para></para>. I fixed that. I also changed the whole thing from
"article" to "book" as all the other *.tmpl files are books.


[...]
<listitem>
+<varname>void *internal_addr</varname>: If you have to access this memory
+region from within your kernel module, you will want to map it internally by
+using something like <function>ioremap_nocache()</function>. Addresses
+returned by this function can not be mapped to user space, so you must not

cannot

Here I also replaced ioremap_nocache() by ioremap(). I just fixed that in
uio_cif.c and don't want to encourage other people to write the same nonsense.

Here's my patch, as I said, it should include your fixes as well:

Index: linux-2.6.22-rc/drivers/uio/uio.c


---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Relevant Pages

  • 2.6.10-as5
    ... Lots of security fixes in here; it's probably a good idea to upgrade. ... Patch stolen from ubuntu. ... skb header corruption. ... struct, when it should be using a compat_cmsghdr struct, instead. ...
    (Linux-Kernel)
  • RE: [Full-Disclosure] 3 new MS patches next week... but none fix
    ... MS does beta test fixes, some companies could be on that beta test program. ... If the company had a real patch that they developed from detailed purchased ... something they called "virtual patches", which he was quite smug about. ...
    (Full-Disclosure)
  • Re: Fixes for nforce2 hard lockup, apic, io-apic, udma133 covered
    ... Trying to get a grasp on the all the fixes floating around. ... So the consensus seems to be that Ross's timer patch and the ... and one with those fixes and Maciej's acpi fixes below. ...
    (Linux-Kernel)
  • Re: [PATCH] serial driver PMC MSP71xx, kernel linux-mips.git mast er
    ... Fix for DesignWare APB THRE errata: ... > fixes it so we have dropped our initial workaround. ... > This patch now needs to be applied on top of that "mm" patch. ...
    (Linux-Kernel)
  • [ANNOUNCE] Linux 2.4.32-hf32.2
    ... wan sdla: fix probable security hole ... The following patch fixes a race condition that allows local users to ... Multicast source filters aren't widely used yet, ...
    (Linux-Kernel)