Re: libata reset-seq merge broke sata_sil on sh

Some more thoughts.

Tejun Heo wrote:
Hello,

Paul Mundt wrote:
[--snip, thanks a lot for the detailed report--]
However, if I go back before any of the reset changes were introduced,
things were working fine, and there were no problems with waiting for
the reset. Ideas?

Hmm... It worked so well on all my sil's. I'm a bit puzzled because we
also failed the same condition before the change too. The only change
is we're less patient with the initial tries but in the end we give more
than enough time to the device to prepare itself.

* Does your drive start spun down when it boots? Can you post dmesg
with printk timestamp turned on with kernel prior to reset-seq merge?

* In ata_bus_softreset() and sata_std_hardreset(), there's msleep(150)
delay before checking the status post-reset. Does increasing the delay
make any difference? Please try to increase it exponentially till it
reaches 10sec.

* According to the report, things still work till 27c78b37 - commit for
the actual merge and there's no related change till the current master
from there. So, which commit actually breaks detection? Or is
detection just flaky after b8cffc6a?

* How does things work on 9b89391c?

Also, please turn on printk timestamp on all reports so that we can now
the timeline of things.

Thanks.

--
tejun
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Relevant Pages

  • RE: [PATCH] sata_nv,adma: fix error when rmmod sata_nv
    ... Tejun Heo wrote: ... I have seen your commit. ... This email message is for the sole use of the intended recipientand may contain ... If you are not the intended recipient, ...
    (Linux-Kernel)
  • Re: [bug] latest -git boot hang
    ... | 870d6656126add8e383645732b03df2b7ccd4f94 is first bad commit ... | Author: Tejun Heo ... and meanwhile 2 other test-systems failed to boot as well - both have ... really only reasonably enabled for some very specialized distro debuggers, ...
    (Linux-Kernel)
  • Re: linux-next: Tree for August 27
    ... On Fri, Aug 29 2008, Tejun Heo wrote: ... introduced by commit 3e5ba59bbab878f60b8b87004ac55a464bddc819 ("block: ... in no longer bootable systems (+ help entry for the new option says ... Bart, can you please elaborate a bit what got ...
    (Linux-Kernel)
  • Re: [stable] [PATCH] block: include empty disks in /proc/diskstats
    ... Tejun Heo wrote: ... zero-sized or not and their non-zero partitions. ... Commit ... behavior such that it doesn't print out zero sized disks. ...
    (Linux-Kernel)
  • Re: Kernel oops: 2.6.16-rc3-mm1 dvd mount
    ... Tejun Heo wrote: ... seems like SCSI midlayer refcounting mixup. ... I'll dig deeper and report again as soon as I can find something concrete. ... I've bisected the patch series and the winner is #221 git-scsi-misc.patch which seems to contain eight commits. ...
    (Linux-Kernel)