Re: libata reset-seq merge broke sata_sil on sh

Paul Mundt wrote:
Yes, it's spun down at boot. I'll get the logs with the timestamps and
the results of the mdelay() incrementing in the morning when I've got the
board handy again.

I see. That's where the expected initial prereset failure comes from.

On Thu, May 10, 2007 at 01:53:48PM +0200, Tejun Heo wrote:
* According to the report, things still work till 27c78b37 - commit for
the actual merge and there's no related change till the current master
from there. So, which commit actually breaks detection? Or is
detection just flaky after b8cffc6a?

The detection is simply flaky after that point, however before the
current master it never hit the 35 second point (and thus never implied
that the link was down). I'll double check the bisect log to see if there
was anything beyond that that may have caused it.

The -ENODEV at least implies that the SRST fails, so at least that's a
starting point.

If prereset() fails to get the initial DRDY before 10secs, it assumes
something went wrong and escalates to hardreset. sil family of
controllers report 0xff status while the link is broken and it seems
that your particular drive needs more than the current 150ms to recover
phy link. It probably went unnoticed till now because the device was
never hardreset before. If the diagnosis is correct, increasing the
delay in hardreset should fix the problem. Well, let's see. :-)

One other curious thing is that it seems to misreport the IRQ. In this
case the log indicates 0, whereas it's actually on IRQ 66. When the
system is booted, /proc/interrupts reflects that sata_sil is on the
proper IRQ (even when it's reported as 0 in the boot printk()).

That's somthing I've missed during init model conversion. It's just
printk problem. I'll fix it.

Thanks.

--
tejun
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/