Re: undefined reference to `__clear_user' (was: Re: [patch 2/13] signal/timer/event fds v10 - signalfd core ...)
- From: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
- Date: Mon, 14 May 2007 22:24:29 +0200 (CEST)
On Sun, 13 May 2007, Andrew Morton wrote:
On Sun, 13 May 2007 12:28:23 +0200 (CEST) Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote:
On Mon, 2 Apr 2007, Davide Libenzi wrote:
--- /dev/null 1970-01-01 00:00:00.000000000 +0000
+++ linux-2.6.21-rc5.fds/fs/signalfd.c 2007-04-02 15:06:29.000000000 -0700
+/*^^^^^^^^^^^^
+ * Copied from copy_siginfo_to_user() in kernel/signal.c
+ */
+static int signalfd_copyinfo(struct signalfd_siginfo __user *uinfo,
+ siginfo_t const *kinfo)
+{
+ long err;
+
+ BUILD_BUG_ON(sizeof(struct signalfd_siginfo) != 128);
+
+ /*
+ * Unused memebers should be zero ...
+ */
+ err = __clear_user(uinfo, sizeof(*uinfo));
Shouldn't this be `clear_user()'? I don't see any access_ok() calls
before this call (I do see them in copy_siginfo_to_user() in
kernel/signal.c), but of course I may miss something...
I only noticed because m68k doesn't have __clear_user(), as this routine
was never needed by generic code before your change.
The vfs does the access_ok() checking on entry to read, write, readv,
writev, pread and pwrite.
I _think_ that covers everything, in which case all the code which
implements reading and writing can use the __ functions. We have a lot of
code which doesn't avail itself of that optimisation though: 12 zillion
sysfs and proc handlers, for a start.
(I think. I only recently noticed this and might have missed a path).
OK, in that case, I'll add __clear_user().
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
- References:
- Prev by Date: Re: [announce] Intel announces the PowerTOP utility for Linux
- Next by Date: Re: [PATCH 0/5] make slab gfp fair
- Previous by thread: Re: undefined reference to `__clear_user' (was: Re: [patch 2/13] signal/timer/event fds v10 - signalfd core ...)
- Next by thread: [PATCH] m68k: implement __clear_user()
- Index(es):
Relevant Pages
|
