Re: [PATCH] Kconfig powernow-k8 driver should depend on ACPI P-States driver

Daniel Drake wrote:
Ed Sweetman wrote:
Like i mentioned off list, the problem here is that cpu freq modules dont depend (Kconfig) on CONFIG_ACPI_PROCESSOR, yet they do.

Not really. Firstly, some of the cpufreq modules *do* depend on CONFIG_ACPI_PROCESSOR. Secondly, the ones that don't have an existing dependency do not actually depend on ACPI_PROCESSOR in some/most configurations.

I'll send in a patch to fix the real problem soon.

Daniel

The way i patched it was to just include a "select ACPI_PROCESSOR" in
the X86_POWERNOW_K8 Kconfig entry.

Since the "driver" that the user sees in the Kconfig is X86_POWERNOW_K8
is actually not a driver at all, our actual driver behaves differently
since the "pseudo" driver only depends is CPUFREQ. This is misleading,
as the actual driver beneath it, depends on ACPI_PROCESSOR too. Now the
driver beneath it responds as you'd think. It disables itself when it's
depends lines are invalid. Which is good. But the menu entry that we
see is for X86_POWERNOW_K8, and that isn't disabled or anything when
those depends lines of the driver it actually represents fails.


This is easily fixed with the select line in the "pseudo" driver
...which i find a little more appropriate than a depends line.


As for actual module dependency issues, i haven't bothered looking into
that. As far as the Kconfig shows it shouldn't be allowed to have
ACPI_PROCESSOR as a module at all. So maybe that's intended.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Relevant Pages

  • Re: [patch, -git] input: CONFIG_INPUT_APANEL build fix
    ... this driver has a missing CONFIG_NEW_LEDS dependency. ... Isn't this a Kconfig issue though? ... The current rule is to fix things up as much as we can ...
    (Linux-Kernel)
  • Re: [patch, -git] input: CONFIG_INPUT_APANEL build fix
    ... this driver has a missing CONFIG_NEW_LEDS dependency. ... Isn't this a Kconfig issue though? ... useful and because 2) users can stumble across that .config combination ...
    (Linux-Kernel)
  • Re: Kconfig warnings on latest GIT
    ... commit 7d776cb596994219584257eb5956b87628e5deaf ... etc. There's a QE library and a bunch of other support code in the ... Kconfig option, like UCC_FAST_TEMP in the driver's Kconfig. ... The dillema is that there is no single device driver class that depends on ...
    (Linux-Kernel)
  • Re: [patch] MTD: fix DOC2000/2001/2001PLUS build error
    ... DiskOnChip driver. ... yeah, i mis-analyzed the point of breakage - and my Kconfig hack simply ... I come across this frequently -- and I just look at the Kconfig file ... to see the dependencies of the option I want to enable. ...
    (Linux-Kernel)
  • Re: [patch 01/10] e1000e: make E1000E default to the same kconfig setting as E1000
    ... Make E1000E default to the same kconfig setting as E1000. ... are expected to have put thought into the Kconfig selection and driver migration strategies. ... PCI IDs move across drivers from time, and we don't want to apply these sorts changes: Viewed in the long term, the suggested patch is merely a temporary change to allow kernel experts to more easily deal with the PCI ID migration across drivers. ...
    (Linux-Kernel)