[PATCH] Fix roundup_pow_of_two(1)
- From: Rolf Eike Beer <eike-kernel@xxxxxxxxx>
- Date: Thu, 17 May 2007 23:56:56 +0200
Fix roundup_pow_of_two(1)
1 is a power of two, therefore roundup_pow_of_two(1) should return 1. It does
in case the argument is a variable but in case it's a constant it behaves
wrong and returns 0. Probably nobody ever did it so this was never noticed.
Signed-off-by: Rolf Eike Beer <eike-kernel@xxxxxxxxx>
---
commit 01ceeffac83011f0b5021013cc4abd1c4f291df5
tree 7da59df51617d7cebd55e4361019181645a17e10
parent ab35916f807eb4f2019a208e96cb0bddbb91dfc3
author Rolf Eike Beer <eike-kernel@xxxxxxxxx> Thu, 17 May 2007 23:43:54 +0200
committer Rolf Eike Beer <eike-kernel@xxxxxxxxx> Thu, 17 May 2007 23:43:54 +0200
include/linux/log2.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/include/linux/log2.h b/include/linux/log2.h
index 57e641e..1b8a2c1 100644
--- a/include/linux/log2.h
+++ b/include/linux/log2.h
@@ -159,7 +159,7 @@ unsigned long __roundup_pow_of_two(unsigned long n)
#define roundup_pow_of_two(n) \
( \
__builtin_constant_p(n) ? ( \
- (n == 1) ? 0 : \
+ (n == 1) ? 1 : \
(1UL << (ilog2((n) - 1) + 1)) \
) : \
__roundup_pow_of_two(n) \
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
- Prev by Date: [problem 2.6.21 libata] using ATA_PIIX throws exceptions, messes up during dvd burn
- Next by Date: [PATCH] MM: use DIV_ROUND_UP() in mm/memory.c
- Previous by thread: [problem 2.6.21 libata] using ATA_PIIX throws exceptions, messes up during dvd burn
- Next by thread: [no subject]
- Index(es):
Relevant Pages
|
