Re: [PATCH 2/2] sysfs: fix race condition around sd->s_dentry, take#2

Maneesh Soni wrote:

Looks ok to me.. I have tested it it but unfortunately I couldn't
recreate the race without the patch also. It would be helpful if
people actually seeing the race, provide the test results.

Greg, please merge this one once we have some test results.

I merged this back to RHEL4-era (2.6.9) kernels due to a report of this
problem on RHEL4. The tester could hit the sysfs_d_iput bug fairly
easily before, and has not seen it with this patch in place.

The other bug they were seeing even more often was the sysfs_readdir()
oops as we try to extract the inode number for regular sysfs files,
again due to transient vnodes. Is any fix for that problem being
considered for -stable? I had backported a simpler version of Tejun's
s_ino fix for the problem, without the ida complexity - and brought a
couple other small upstream fixes back to support that. If nothing has
yet been proposed for -stable, I can post that here.

Thanks,

-Eric
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Relevant Pages

  • 2.6.27-rc1-mm1
    ... See the `hot-fixes' directory for any important updates to this patchset. ... If you hit a bug in -mm and it is not obvious which patch caused it, ... CIFS fix ...
    (Linux-Kernel)
  • Re: thoughts on kernel security issues
    ... having two independent patches that fix them is STILL better. ... Take it from me - I've been reviewing patches for _way_ too long. ... have a clue ("try reverting that one patch") or you can do things like ... Which is why lots of small patches usually have _different_ bug behaviour ...
    (Linux-Kernel)
  • 2.6.22-rc4-mm2
    ... trees were repulled, several bad patches were dropped, a few were fixed. ... If you hit a bug in -mm and it is not obvious which patch caused it, ... wireless sparse fix ...
    (Linux-Kernel)
  • Re: panic in RELENG_5 UMA - two new stack traces
    ... We definitely see that the bug is a race, ... there is one for race between incoming ARP reply and ... Does it look like fixing this bug may fix a lot of the ...
    (freebsd-stable)
  • 2.6.17-rc4-mm3
    ... If you hit a bug in -mm and it is not obvious which patch caused it, ... Driver tree updates ... Fix reject in git-nfs.patch. ...
    (Linux-Kernel)