[PATCH] smpboot: cachesize comparison fix in smp_tune_scheduling()
- From: Jarek Poplawski <jarkao2@xxxxx>
- Date: Thu, 24 May 2007 12:33:23 +0200
smpboot: cachesize comparison fix in smp_tune_scheduling()
boot_cpu_data.x86_cache_size is signed int and can be < 0 too.
PS: this function is removed from current -mm.
Signed-off-by: Jarek Poplawski <jarkao2@xxxxx>
---
diff -Nurp 2.6.22-rc2-git5-/arch/i386/kernel/smpboot.c 2.6.22-rc2-git5/arch/i386/kernel/smpboot.c
--- 2.6.22-rc2-git5-/arch/i386/kernel/smpboot.c 2007-05-24 09:37:11.000000000 +0200
+++ 2.6.22-rc2-git5/arch/i386/kernel/smpboot.c 2007-05-24 11:48:03.000000000 +0200
@@ -948,7 +948,7 @@ static void smp_tune_scheduling(void)
if (cpu_khz) {
cachesize = boot_cpu_data.x86_cache_size;
- if (cachesize > 0)
+ if ((long)cachesize > 0)
max_cache_size = cachesize * 1024;
}
}
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
- Follow-Ups:
- Re: [PATCH] smpboot: cachesize comparison fix in smp_tune_scheduling()
- From: Andrew Morton
- Re: [PATCH] smpboot: cachesize comparison fix in smp_tune_scheduling()
- Prev by Date: back on linux-kernel
- Next by Date: Re: How to access correctly serial port inside module?
- Previous by thread: back on linux-kernel
- Next by thread: Re: [PATCH] smpboot: cachesize comparison fix in smp_tune_scheduling()
- Index(es):
Relevant Pages
|