Re: [PATCH 2/4] AFS: Add a function to excise a rejected write from the pagecache

Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:

hm. I don't see why that race window would be a problem in practice: the
page-exciser does a lock_page();wait_on_page_writeback() as normal, then
proceeds with its business?

No. The page-exciser ends (cancels) PG_writeback, not waits for it (something
has to clear the flag). The problem is that the truncation routines may be
sat there holding a lock on the page whilst waiting for PG_writeback to go
away - so we have to clear PG_writeback before we can think about getting
PG_lock:-(

But given that this doesn't work right for some reason, can we use PG_error
and then handle that appropriately in the filesystem's ->prepare_write() and
->page_mkwrite()?

Possibly, though I'd rather they didn't see such a page.

David
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Relevant Pages

  • Re: Happy Independance Day To all
    ... in air gave proof through the night that our flag was still there. ... Requiring protestors to go to free speech zones which are miles from ... attempting to pass a anti-flag burning amendment ... flies dirty red/white/blue rags infront of their business? ...
    (rec.gardens)
  • Re: Damn you, FEDEX! or Nikon D40 lost in Springfield, MO blackhole.
    ... the 2 mp Mavica he had been using with a Nikon D40. ... After shopping around, he got me to order one for him. ... The shipper had it insured, but from what I have read it could take weeks to sort this crap out. ... You may get your insurance from FedEx and a couple weeks later they find it and deliver it. ...
    (alt.photography)
  • Re: Library functions vs System calls
    ... It's none of ones business. ... some functions as cancellations points? ... > One does not call anything from a signal handler - just set a flag and ... > let a regular service routine pick up on the flag. ...
    (comp.os.linux.development.apps)
  • Re: Library functions vs System calls
    ... It's none of ones business. ... some functions as cancellations points? ... > One does not call anything from a signal handler - just set a flag and ... > let a regular service routine pick up on the flag. ...
    (comp.os.linux.development.system)
  • Re: [PATCH 2/4] AFS: Add a function to excise a rejected write from the pagecache
    ... proceeds with its business? ... The page-exciser ends (cancels) PG_writeback, ... has to clear the flag). ...
    (Linux-Kernel)