Re: [PATCH 1/1] V4L: stk11xx, add a new webcam driver

On 5/24/07, Markus Rechberger <mrechberger@xxxxxxxxx> wrote:
Hi Jiri,

On 5/24/07, Jiri Slaby <jirislaby@xxxxxxxxx> wrote:
> Well, no objections on v4l list, try to merge it. Any further comments will
> be
> appreciated.
>
> --
>
> stk11xx, add a new webcam driver
[...]
> +static int stk1125_camera_asleep(struct stk11xx *dev)
> +{
> + int value;
> +
> + stk11xx_read_registry(dev, 0x0104, &value);
> + stk11xx_read_registry(dev, 0x0105, &value);
> + stk11xx_read_registry(dev, 0x0106, &value);
> +

why do you read these values (this is also something in the ongoing
code I see, the read value just gets overwritten all the time)?

Well, as I tested, reads are neccesary, otherwise it doesn't work. And
when they are needed, you need to read the value to some place in
memory -- the &value.

thanks,
--
http://www.fi.muni.cz/~xslaby/ Jiri Slaby
faculty of informatics, masaryk university, brno, cz
e-mail: jirislaby gmail com, gpg pubkey fingerprint:
B674 9967 0407 CE62 ACC8 22A0 32CC 55C3 39D4 7A7E
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/