Re: [PATCH 2/4] AFS: Add a function to excise a rejected write from the pagecache
- From: David Howells <dhowells@xxxxxxxxxx>
- Date: Fri, 25 May 2007 00:37:45 +0100
Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
But we already covered that? Your exciser can do an unconditional
end_page_writeback(), because it is this thread of control which did the
set_page_writeback(). So we end up with:
Ah, I misunderstood what you meant. I assumed you meant to wait insted of
ending.
Of course, if we've decided to excise this page, it really oughtn't to get
PG_writeback set again. I'll have to think about that.
Well someone needs to be taught all about this case. Question is, should
it be the VFS, or should it just be the address_space(s) which brought
this state about, and which care about it?
For the most part, I think that this only applies to netfs's, and possibly not
all of those, so making it fully general might be overkill.
David
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
- References:
- Re: [PATCH 2/4] AFS: Add a function to excise a rejected write from the pagecache
- From: Andrew Morton
- Re: [PATCH 2/4] AFS: Add a function to excise a rejected write from the pagecache
- From: Andrew Morton
- Re: [PATCH 2/4] AFS: Add a function to excise a rejected write from the pagecache
- From: Andrew Morton
- Re: [PATCH 2/4] AFS: Add a function to excise a rejected write from the pagecache
- From: Andrew Morton
- [PATCH 1/4] AFS: Add TestSetPageError()
- From: David Howells
- [PATCH 2/4] AFS: Add a function to excise a rejected write from the pagecache
- From: David Howells
- Re: [PATCH 2/4] AFS: Add a function to excise a rejected write from the pagecache
- From: David Howells
- Re: [PATCH 2/4] AFS: Add a function to excise a rejected write from the pagecache
- From: David Howells
- Re: [PATCH 2/4] AFS: Add a function to excise a rejected write from the pagecache
- From: David Howells
- Re: [PATCH 2/4] AFS: Add a function to excise a rejected write from the pagecache
- Prev by Date: Re: HPT366 not enabled by kernel 2.6.21.2
- Next by Date: Re: [PATCH] Display Intel Dynamic Acceleration feature in /proc/cpuinfo
- Previous by thread: Re: [PATCH 2/4] AFS: Add a function to excise a rejected write from the pagecache
- Next by thread: Re: [PATCH 2/4] AFS: Add a function to excise a rejected write from the pagecache
- Index(es):
Relevant Pages
|