Re: [PATCH 2.6.21] cramfs: add cramfs Linear XIP

Christoph Hellwig wrote:
I might be a little late in the discussion, but I somehow missed this
before. Please don't add this xip support to cramfs, because the
whole point of cramfs is to be a simple _compressed_ filesystem,
and we really don't want to add more complexity to it. Please
use something like the existing ext2 xip mode instead of add support
to romfs using the generic filemap methods.
The clear advantage of using cramfs on embedded platforms over using the
ext2 stuff is, that one can choose per-file whether it should be
compressed or xip.
The real key is, to put both our ext2 stuff and the cramfs xip on a common infrastructure. They should use the same file operations and adress space operations for xip files rather then replicating each others bugs.
If cramfs shall be kept simple, it might be time to fork that file system. I don't see that need arise from the proposed solution. It can become clean and sane with a little work on it. Look at the xip extensions for ext2 for example, they don't bloat the filesystem too much.

so long,
Carsten
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/