Re: [RFC PATCH 0/6] Convert all tasklets to workqueues



On Fri, 22 Jun 2007, Ingo Molnar wrote:

* Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:

Whether we actually then want to do 6 is another matter. I think we'd
need some measuring and discussion about that.

basically tasklets have a number of limitations:

I'm not disputing that they aren't pretty.

But none of your arguments really touch on the deeper issue:

- Is the new code *technically*better*?

Don't get me wrong. I like cleanups as much as the next guy. I have no
problem at all with the first four patches in the series, because those
are cleanups that have no technical impact apart from that "cleanup-ness".

The reason I ask about patch #6 is simply that in the end "clean code"
matters less than "good results".

I'm a _huge_ believer in "clean code", but the fact is, I'm an even bigger
believer in "reality bites". I'd really like to see some numbers.

If the numbers say that there is no performance difference (or even
better: that the new code performs better or fixes some latency issue or
whatever), I'll be very happy. But if the numbers say that it's worse, no
amount of cleanliness really changes that.

Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/