Re: [RFC PATCH 0/6] Convert all tasklets to workqueues
- From: Jeff Garzik <jeff@xxxxxxxxxx>
- Date: Thu, 28 Jun 2007 01:48:40 -0400
Ingo Molnar wrote:
so how about the following, different approach: anyone who has a tasklet in any performance-sensitive codepath, please yell now. We'll also do a proactive search for such places. We can convert those places to softirqs, or move them back into hardirq context. Once this is done - and i doubt it will go beyond 1-2 places - we can just mass-convert the other 110 places to the lame but compatible solution of doing them in a global thread context.
Color me unconvinced.
Tasklets fill a niche not filled by either workqueues (slower, requiring context switches, and possibly much latency is all wq's processes are active) or softirqs (limited number of them, not flexible at all). Sure, tasklets kick over to ksoftirqd, but not immediately, and therein lies their value.
And moving code -back- into hardirq is just the wrong thing to do, usually.
This proposal is ENTIRELY derived from "not convenient to my project" logic AFAICS, rather than the more sound "not needed in the kernel."
Jeff
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
- Follow-Ups:
- Re: [RFC PATCH 0/6] Convert all tasklets to workqueues
- From: Ingo Molnar
- Re: [RFC PATCH 0/6] Convert all tasklets to workqueues
- References:
- [RFC PATCH 0/6] Convert all tasklets to workqueues
- From: Steven Rostedt
- Re: [RFC PATCH 0/6] Convert all tasklets to workqueues
- From: Linus Torvalds
- Re: [RFC PATCH 0/6] Convert all tasklets to workqueues
- From: Ingo Molnar
- Re: [RFC PATCH 0/6] Convert all tasklets to workqueues
- From: Linus Torvalds
- Re: [RFC PATCH 0/6] Convert all tasklets to workqueues
- From: Ingo Molnar
- [RFC PATCH 0/6] Convert all tasklets to workqueues
- Prev by Date: Re: [AppArmor 00/44] AppArmor security module overview
- Next by Date: Re: [PATCH] CodingStyle: Add information about trailing whitespace.
- Previous by thread: Re: [RFC PATCH 0/6] Convert all tasklets to workqueues
- Next by thread: Re: [RFC PATCH 0/6] Convert all tasklets to workqueues
- Index(es):