[PATCH 1/4] void unregister_blkdev - do WARN_ON failure
- From: Akinobu Mita <akinobu.mita@xxxxxxxxx>
- Date: Sat, 30 Jun 2007 12:10:13 +0900
When unregister_blkdev() has failed, something wrong happened.
This patch adds WARN_ON to notify such badness.
Cc: Jens Axboe <jens.axboe@xxxxxxxxxx>
Signed-off-by: Akinobu Mita <akinobu.mita@xxxxxxxxx>
---
block/genhd.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
Index: 2.6-mm/block/genhd.c
===================================================================
--- 2.6-mm.orig/block/genhd.c
+++ 2.6-mm/block/genhd.c
@@ -120,9 +120,10 @@ int unregister_blkdev(unsigned int major
for (n = &major_names[index]; *n; n = &(*n)->next)
if ((*n)->major == major)
break;
- if (!*n || strcmp((*n)->name, name))
+ if (!*n || strcmp((*n)->name, name)) {
+ WARN_ON(1);
ret = -EINVAL;
- else {
+ } else {
p = *n;
*n = p->next;
}
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
- Follow-Ups:
- [PATCH 4/4] void unregister_blkdev - make void
- From: Akinobu Mita
- [PATCH 3/4] void unregister_blkdev - ignore the return value
- From: Akinobu Mita
- [PATCH 2/4] void unregister_blkdev - delete redundant messages
- From: Akinobu Mita
- [PATCH 4/4] void unregister_blkdev - make void
- Prev by Date: [PATCH 2/2] void unregister_chrdev - make void
- Next by Date: [PATCH 2/4] void unregister_blkdev - delete redundant messages
- Previous by thread: [PATCH 1/2] void unregister_chrdev - ignore the return value
- Next by thread: [PATCH 2/4] void unregister_blkdev - delete redundant messages
- Index(es):
Relevant Pages
|
