Re: [PATCH 2/4 -mm] void unregister_blkdev - delete redundant message
- From: "Grant Likely" <grant.likely@xxxxxxxxxxxx>
- Date: Sat, 30 Jun 2007 02:15:50 -0400
On 6/29/07, Akinobu Mita <akinobu.mita@xxxxxxxxx> wrote:
No need to warn unregister_blkdev() failure by caller.Acked-by: Grant Likely <grant.likely@xxxxxxxxxxxx>
(The previous patch makes unregister_blkdev() print error message in
error case)
Cc: Grant Likely <grant.likely@xxxxxxxxxxxx>
Signed-off-by: Akinobu Mita <akinobu.mita@xxxxxxxxx>
---
drivers/block/xsysace.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
Index: 2.6-mm/drivers/block/xsysace.c
===================================================================
--- 2.6-mm.orig/drivers/block/xsysace.c
+++ 2.6-mm/drivers/block/xsysace.c
@@ -1157,9 +1157,7 @@ static void __exit ace_exit(void)
{
pr_debug("Unregistering Xilinx SystemACE driver\n");
driver_unregister(&ace_driver);
- if (unregister_blkdev(ace_major, "xsysace"))
- printk(KERN_WARNING "systemace unregister_blkdev(%i) failed\n",
- ace_major);
+ unregister_blkdev(ace_major, "xsysace");
}
module_init(ace_init);
--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
grant.likely@xxxxxxxxxxxx
(403) 399-0195
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
- References:
- [PATCH 1/4] void unregister_blkdev - do WARN_ON failure
- From: Akinobu Mita
- [PATCH 2/4] void unregister_blkdev - delete redundant messages
- From: Akinobu Mita
- [PATCH 2/4 -mm] void unregister_blkdev - delete redundant message
- From: Akinobu Mita
- [PATCH 1/4] void unregister_blkdev - do WARN_ON failure
- Prev by Date: Re: [PATCH 2/4] void unregister_blkdev - delete redundant messages
- Next by Date: Re: how about mutual compatibility between Linux's GPLv2 and GPLv3?
- Previous by thread: [PATCH 2/4 -mm] void unregister_blkdev - delete redundant message
- Next by thread: Re: [PATCH 2/4] void unregister_blkdev - delete redundant messages
- Index(es):
Relevant Pages
|
|