Re: [PATCH 2/4] void unregister_blkdev - delete redundant messages

From: "Grant Likely" <grant.likely@xxxxxxxxxxxx>
Date: Sat, 30 Jun 2007 10:12:53 -0400

On 6/30/07, Akinobu Mita <akinobu.mita@xxxxxxxxx> wrote:

> Seeing as none of the callers check the error code; why does the
> function return anything at all?

Right. This series of patches is trying to make it return void.

http://lkml.org/lkml/2007/6/29/320

Heh, cool. I should do more research before I reply blindly. :-)

g.

--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
grant.likely@xxxxxxxxxxxx
(403) 399-0195
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

References:
- [PATCH 1/4] void unregister_blkdev - do WARN_ON failure
  - From: Akinobu Mita
- [PATCH 2/4] void unregister_blkdev - delete redundant messages
  - From: Akinobu Mita
- Re: [PATCH 2/4] void unregister_blkdev - delete redundant messages
  - From: Grant Likely
- Re: [PATCH 2/4] void unregister_blkdev - delete redundant messages
  - From: Akinobu Mita

Prev by Date: Re: [PATCH 2/4] void unregister_blkdev - delete redundant messages
Next by Date: Re: 2.6.22-rc6 spurious hangs
Previous by thread: Re: [PATCH 2/4] void unregister_blkdev - delete redundant messages
Next by thread: [PATCH 3/4] void unregister_blkdev - ignore the return value
Index(es):
- Date
- Thread

Relevant Pages

Re: [PATCH 5/5] cdrom: make unregister_cdrom() return void
... On Sat, Mar 22 2008, Akinobu Mita wrote: ... Make it return void and update all callers that check the return value. ... Patches 1-3 and 5 are fine, ...
(Linux-Kernel)
[PATCH] PER_CPU [2/4] - PER_CPU-init_tss
... variables to the per-cpu area. ... Patches tested using make allmodconfig, and defconfig, and ... void __init cpu_init ... extern struct cpuinfo_x86 boot_cpu_data; ...
(Linux-Kernel)
[PATCH 1/2] Make x86_64 udelay() round up instead of down - try2
... Port two patches from i386 to x86_64 delay.c to make sure all rounding is done ... There is no sign in commit messages that the mismatch was done on purpose, ... now it is a real round up rather than "round down and add 1" ... inline void __const_udelay ...
(Linux-Kernel)
Re: [PATCH] 2.6, 2.4, Nforce2, Experimental idle halt workaround instead of apic ack delay.
... than it does with Linux when idle. ... required when my cpu is at 36 deg. than when it is at 50+ idle. ... without Ross' patches would not react this vigorously. ... > static void poll_idle ...
(Linux-Kernel)
[PATCH 1/2] Make x86_64 udelay() round up instead of down.
... Port two patches from i386 to x86_64 delay.c to make sure all rounding is done ... upward instead of downward. ... There is no sign in commit messages that the mismatch was done on purpose, ... inline void __const_udelay ...
(Linux-Kernel)