Re: [patch 09/10] Remove the SLOB allocator for 2.6.23

Christoph Lameter wrote:
On Tue, 10 Jul 2007, Nick Piggin wrote:


I don't see any problems with maintaining SLOB. It is simple enough
that I was able to write a userspace test harness for it and hack
away at it after reading the code the first time for half an hour or
so. It is nothing even slightly comparable to the problems of SLAB,
for example. And you don't have to maintain it at all anyway!


I have to maintain it because I have to keep the slab APIs consistent (recently I added GFP_ZERO support and had to provide shims for slab defreag). It is not in a good state as described in the patch and has a history of not being maintained properly. Everyone that modifies the behavior of the slab allocator has to do something to avoid breaking SLOB. Its certainly fun to hack on but is that a criterion for keeping it in the tree?

Pretty standard fare that when you add something or change APIs, most
of the burden is on you to not break the kernel. I'd love nothing better
than to remove all but about 3 filesystems :)

It is reasonable to expect some help from maintainers, but I notice you
didn't even CC the SLOB maintainer in the patch to remove SLOB! So maybe
if you tried working a bit closer with him you could get better results?


I like removing code as much as the next person, but I don't
understand why you are so intent on removing SLOB and willing to
dismiss its advantages so quickly.


Quickly? We have considered this for months now.

Quickly -- as in you quickly sweep the savings of 100s of K under the
rug and just declare that it is insignificant :)

--
SUSE Labs, Novell Inc.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Relevant Pages

  • Re: [PATCH RT 00/02] SLOB optimizations
    ... >> The old SLOB did the old K&R memory allocations. ... > 16MB of memory, so the linked list walking is pretty well bounded. ... I think this is due to the complexity of the current SLAB. ...
    (Linux-Kernel)
  • [PATCH RT 00/02] SLOB optimizations
    ... The old SLOB did the old K&R memory allocations. ... I'm simple used the method of SLAB to use the lru list field of the ... sys 0m3.149s ...
    (Linux-Kernel)
  • [GIT PULL] SLAB updates for 2.6.30-rc1
    ... Please pull the latest SLAB three which contains the following changes: ... Assorted cleanups to SLUB and SLOB ... move min_partial to struct kmem_cache ...
    (Linux-Kernel)
  • [patch 09/10] Remove the SLOB allocator for 2.6.23
    ... The SLOB allocator in particular has been lagging ... Still has no support for slab reclaim counters. ... The density of non kmalloc slabs is superior in SLUB since SLOB has the need ...
    (Linux-Kernel)
  • Re: [patch 09/10] Remove the SLOB allocator for 2.6.23
    ... away at it after reading the code the first time for half an hour or ... It is nothing even slightly comparable to the problems of SLAB, ... behavior of the slab allocator has to do something to avoid breaking SLOB. ... Its certainly fun to hack on but is that a criterion for keeping it in the ...
    (Linux-Kernel)