Re: [PATCH 1/3] [net/core] move dev_mc_discard from dev_mcast.c to dev.c
- From: David Miller <davem@xxxxxxxxxxxxx>
- Date: Wed, 18 Jul 2007 02:11:07 -0700 (PDT)
From: Denis Cheng <crquan@xxxxxxxxx>
Date: Wed, 18 Jul 2007 10:41:03 +0800
Because this function is only called by unregister_netdevice,
this moving could make this non-global function static,
and also remove its declaration in netdevice.h;
Any further, function __dev_addr_discard is also just called by
dev_mc_discard and dev_unicast_discard, keeping this two functions
both in one c file could make __dev_addr_discard also static
and remove its declaration in netdevice.h;
Futhermore, the sequential call to dev_unicast_discard and then
dev_mc_discard in unregister_netdevice have a similar mechanism that:
(netif_tx_lock_bh / __dev_addr_discard / netif_tx_unlock_bh),
they should merged into one to eliminate duplicates in acquiring and
releasing the dev->_xmit_lock, this would be done in my following patch.
Signed-off-by: Denis Cheng <crquan@xxxxxxxxx>
Patch applied, thanks.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
- Follow-Ups:
- References:
- [PATCH 1/4] [NET] move dev_mc_discard from dev_mcast.c to dev.c
- From: Denis Cheng
- [PATCH 1/3] [net/core] move dev_mc_discard from dev_mcast.c to dev.c
- From: Denis Cheng
- [PATCH 1/4] [NET] move dev_mc_discard from dev_mcast.c to dev.c
- Prev by Date: Re: [PATCH 1/3] Standardize x86_64's desc_defs.h in preparation for exposure to i386.
- Next by Date: Re: [PATCH 2/3] [net/core] merge dev_unicast_discard and dev_mc_discard into one
- Previous by thread: Re: [PATCH 2/3] [net/core] merge dev_unicast_discard and dev_mc_discard into one
- Next by thread: Re: [PATCH 1/3] [net/core] move dev_mc_discard from dev_mcast.c to dev.c
- Index(es):
Relevant Pages
|
