Re: [PATCH 1/3] [net/core] move dev_mc_discard from dev_mcast.c to dev.c

David Miller wrote:
From: Patrick McHardy <kaber@xxxxxxxxx>
Date: Wed, 18 Jul 2007 12:01:38 +0200


rae l wrote:

All in one word, I don't think the single file dev_mcast.c is needed
anymore.

Agreed. But dev.c is growing larger and larger, maybe dev_addr.c?
Or dev_config.c, with some of the other device configuration functions?


I don't know, a sizable dev.c is inevitable, allows better refactoring
and consolidation. And the be honest you're going to have to likely
touch things in dev.c whenever you make changes to dev_addr.c or
whatever you want to name it. :-)


You're probably right. Killing dev_mcast.c makes sense to me though.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Relevant Pages