[PATCH] Make headers_check less chatty for success cases

Hi David, Sam,

"make headers_check" is too verbose. It likes to chat even if it has
just _successfully_ checked a header, and not just on seeing errors.
What is worse, even if you touch just one little header in some corner
(or possibly none) and type "make" on an "already-made" tree,
headers_check still feels obliged to check all the headers.

Both the above things combined mean that when you're working on your own
little subsystem, and simply "make" an already-made tree, and turn around
to speak to a colleague, then by the time you look back at the screen, it
does not contain any useful warnings from the actual compilation stage.
If you're unlucky, the entire scroll-back history of the xterm would have
also got polluted with headers_check's "CHECK include/linux/foo.h" spam.

As a result I've been totally put off by it and have CONFIG_HEADERS_CHECK=n
set in my .config -- but that could lead to breakages. Hence:


[PATCH] Make headers_check less chatty for success cases

We still echo verbosely (and fail, obviously) for any errors encountered.

Signed-off-by: Satyam Sharma <satyam@xxxxxxxxxxxxx>

---

[ just removing that line also works, but that loses symmetry with others ]

scripts/Makefile.headersinst | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/scripts/Makefile.headersinst b/scripts/Makefile.headersinst
index 53dae3e..0a23dd9 100644
--- a/scripts/Makefile.headersinst
+++ b/scripts/Makefile.headersinst
@@ -96,7 +96,7 @@ quiet_cmd_unifdef = UNIFDEF $(patsubst $(INSTALL_HDR_PATH)/%,%,$@)
cmd_unifdef = $(UNIFDEF) $(patsubst $(INSTALL_HDR_PATH)/$(_dst)/%,$(srctree)/$(obj)/%,$@) \
| $(HDRSED) > $@ || :

-quiet_cmd_check = CHECK $(patsubst $(INSTALL_HDR_PATH)/$(_dst)/.check.%,$(_dst)/%,$@)
+quiet_cmd_check =
cmd_check = $(CONFIG_SHELL) $(srctree)/scripts/hdrcheck.sh \
$(INSTALL_HDR_PATH)/include $(subst /.check.,/,$@) $@

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Relevant Pages

  • Re: Headers and Page Numbers Word 2007
    ... will not increment the numbers. ... I have tried putting the field code in a text box and anchoring it to the L ... or R side of the page with no success. ... This throws out the header. ...
    (microsoft.public.word.pagelayout)
  • Re: [PATCH] Make headers_check less chatty for success cases
    ... On Tue, 31 Jul 2007, David Woodhouse wrote: ... and not just on seeing errors. ... even if you touch just one little header in some corner ... being built only on demand ...) ...
    (Linux-Kernel)
  • System.Net.Mail Namespace issues
    ... I have set some properties in the headers with great success, ... to the deliverynoification. ... header and the from field, I get a notification the email was sent ... notified of more than one notification (for instance I want to know of any ...
    (microsoft.public.dotnet.languages.vb)
  • Re: alias
    ... } EMPLOYEE; ... Verbose, but at least you don't have to look at the header to see what ... the members represent. ...
    (comp.lang.c)
  • Re: asp:menu requires Page.Header to be non-null
    ... I am not sure I understand what you're saying. ... with no success. ... Header is dynamically generated. ...
    (microsoft.public.dotnet.framework.aspnet)