Re: [PATCH] argv_split: allow argv_split to handle NULL pointer in argcp parameter gracefully

On Tue, Jul 31, 2007 at 11:06:52PM +0530, Satyam Sharma wrote:


On Tue, 31 Jul 2007, Neil Horman wrote:

As Jeremy and I had discussed in a previous thread, it would be nice if the
argv_split library function could gracefully handle a NULL pointer in the argcp
parameter, so as to allow functions using it that did not care about the value
of argc to not have to declare a useless variable. This patch accomplishes
that. Tested by me, with successful results.

The patch itself looks simple and straightforward enough, but having done
this, now you'd also want to cleanup the use of the dummy variable in the
callsites you mentioned above, correct? (Unless that's what Jeremy meant
in his reply already)

yes, and as I've already replied, I have this patch ready. however, I've got
some other work that I'm doing in one of the callsites, and since there are only
currently two sites, one of which already has some pending changesets in -mm,
I'm waiting for those to get some testing first. Once there are no
issues/requests with my current changesets, I'll be submitting a patch with the
cleanup of the callsites, along with some other changes.

regards
Neil

--
/***************************************************
*Neil Horman
*Software Engineer
*Red Hat, Inc.
*nhorman@xxxxxxxxxxxxx
*gpg keyid: 1024D / 0x92A74FA1
*http://pgp.mit.edu
***************************************************/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Relevant Pages