Re: [PATCH] [1/2many] - FInd the maintainer(s) for a patch - scripts/get_maintainer.pl

Joe Perches <joe@xxxxxxxxxxx> writes:

On Tue, 2007-08-14 at 17:53 +0200, Rene Herman wrote:
It isn't about MODULE_FOO() tags, it is about tagging /source/ files
to help with putting CCs on patch submissals.
If we want to link source file foo.c and the
MAINTAINERS information, we have 3 options:
1. MAINTAINERS --> foo.c
2. foo.c --> MAINTAINERS
3. foo.c <--> some 3rd file <--> MAINTAINERS

I added git@xxxxxxxxxxxxxxx and Junio Hamano

Another possibility is improving git to allow
some sort of "declaration of interest" in bits
of projects.

That would allow options like:

o git-format-patch to include CCs
o git-commit and git-branch to notify or
take some other action

etc...

There are things git can help, and other things git does not
have any business with.

1. Finding out who the potentially interested parties are.

Linus already gave a script to grep *-by: lines from commit
messages. I find this is probably be the best option, as it
follows "yesterday's weather". People who had dealt with the
area are the ones who are likely to be interested.

git records who did the work (author) and who did the
integration to git-based patch flow (committer). It does not
structurally track intermediate people who touched the patch
on e-mail, but Signed-off-by: and Acked-by: (and sometimes I
see Cc: as well in the commit messages) are accepted social
convention in the kernel community, and taking advantage of
that is a good idea.


2. Making it easier to send your patches to these people.

There are three possible places to add Signed-off-by: and
friends in the commit messages you would mail out:

- When you create your own commit, or commit a patch that
came to you via e-mail. The commit object in your tree
will carry them --- you can send format-patch output as-is
to Linus or Andrew and you are done.

- When you run format-patch; your commit will not have extra
Cc: or "interested parties" information, you will use the
result of 1. and insert it near your own Signed-off-by: to
the format-patch output.

- When you send format-patch output, via git-send-email
perhaps.

To make the result useful for "yesterday's weather" approach,
I think it would be the best to do the first. After all,
your commit may propagate via "git pull" not over e-mail, and
no postprocessing approach would work in such a case.

The second one is my least favorite. format-patch output is
designed to record author/committer (i.e. origin) and not to
record recipient at all. "Who's interested in this" does not
simply belong there.

On the other hand, git-send-email _is_ all about sending it
out, and it needs to know who your patch should reach. I
think it makes sense to have one script that, given a set of
paths that are affected, gives a list of potentially
interested people (that is "Finding" part -- and I see there
are 600+ patches to implement this on the list), and a new
option to git-send-email to (1) inspect the patch to see what
paths are affected, and (2) call that "Find" script to figure
out whom to send it to, and probably asking for confirmation.




-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Relevant Pages

  • Re: Linux 2.6.16-rc1
    ... if you want to judge how big a patch is by the number of files it ... that it is a real measure of how likely a commit was to impact other ... some of which are very core (the TTY layer buffering revamp), ... a word of warning - git is efficient, but doing things like the above ...
    (Linux-Kernel)
  • Re: 2.6.18-mm1
    ... then I come to commit it: ... Think of it as "diffstat for git". ... (otherwise you would somehow need to parse the patch and find ... If you _are_ updating index yourself before calling git-commit, ...
    (Linux-Kernel)
  • Re: Please pull ACPI updates
    ... One thing I wish I had in git is a way to make this sequence easier... ... Then I create a new topic branch at the broken patch. ... stable point before the place you want to fix up. ... The normal action is to "pick" the commit. ...
    (Linux-Kernel)
  • Re: Broken "make install" in 2.6.14-git1
    ... > I'm unable to locate that commit, perhaps due to a local lack of gittiness. ... I'm not very good with git. ... All that bisect visualize shows for the patch is the following: ... send the line "unsubscribe linux-kernel" in ...
    (Linux-Kernel)
  • Re: [PATCH 0/10] MAINTAINERS - script, patterns, and misc fixes
    ... Other information from MAINTAINERS sections can ... also be generated by file or patch. ... Christoph Hellwig ... For some (git related) reason it is vastly slower than yours. ...
    (Linux-Kernel)