Re: [PATCH] Increase lockdep MAX_LOCK_DEPTH



On Fri, 2007-08-31 at 09:33 -0500, Eric Sandeen wrote:

Peter, unless there is some other reason to do so, changing xfs
performance behavior simply to satisfy lockdep limitations* doesn't seem
like the best plan.

I suppose one slightly flakey option would be for xfs to see whether
lockdep is enabled and adjust cluster size based on MAX_LOCK_DEPTH... on
the argument that lockdep is likely used in debugging kernels where
sheer performance is less important... but, that sounds pretty flakey to me.

Agreed, that sucks too :-/

I was hoping there would be a 'nice' solution, a well, again, reality
ruins it.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



Relevant Pages

  • Re: 2.6.18 xfs lockdep warning
    ... I'd like to report a lockdep warning with 2.6.18 while unmounting a ... the trace I get is as follows: ... i don't think it is safe to use lockdep with XFS. ...
    (Linux-Kernel)
  • Re: [xfs-masters] Re: 2.6.18-rc6-mm2
    ... Michal, there were several XFS fixes that went into -rc7. ... As I said before "I was wrong" (I use lockdep only with -mm kernels). ... we are oopsing here.... ...
    (Linux-Kernel)
  • Re: BUG: soft lockup detected on CPU#1!
    ... lockdep not to report it instead of an actual bug (and why I CC'd the ... Probably XFS needs to tell lockdep about it's nesting. ... is a bug that is lying in there somewhere. ...
    (Linux-Kernel)
  • Re: [2.6.26-rc7] shrink_icache from pagefault locking (nee: nfsd hangs for a few sec)...
    ... AutopanoPro/4470 is trying to acquire lock: ... You may as well ignore anything invlving this path in XFS until ... off lockdep there is nothing in XFS that can be done to prevent ... should page allocation in a page fault be allowed to recurse ...
    (Linux-Kernel)